Skip to content

fix: skip combineSigShare check for non-EIP191 message signing #6686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
+7 −4
Merged

fix: skip combineSigShare check for non-EIP191 message signing #6686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions modules/sdk-core/src/bitgo/wallet/wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ import { IRequestTracer } from '../../api';
import { getTxRequestApiVersion, validateTxRequestApiVersion } from '../utils/txRequest';
import { getLightningAuthKey } from '../lightning/lightningWalletUtil';
import { SubmitTransactionResponse } from '../inscriptionBuilder';
import { CoinFamily } from '@bitgo/statics';

const debug = require('debug')('bitgo:v2:wallet');

Expand Down Expand Up @@ -3662,10 +3663,12 @@ export class Wallet implements IWallet {
bufferToSign: Buffer.from(messageEncoded, 'hex'),
});
assert(signedMessageRequest.messages, 'Unable to find messages in signedMessageRequest');
assert(
signedMessageRequest.messages[0].combineSigShare,
'Unable to find combineSigShare in signedMessageRequest.messages'
);
if (this.baseCoin.getFamily() === CoinFamily.ETH) {
assert(
signedMessageRequest.messages[0].combineSigShare,
'Unable to find combineSigShare in signedMessageRequest.messages'
);
}
assert(signedMessageRequest.messages[0].txHash, 'Unable to find txHash in signedMessageRequest.messages');
return {
coin: this.coin(),
Expand Down
Loading