feat: added canton coin to statics #7139
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baltiyal
reviewed
Oct 1, 2025
| class Canton extends Mainnet implements BaseNetwork { | ||
| name = 'Canton'; | ||
| family = CoinFamily.CANTON; | ||
| explorerUrl = ''; |
There was a problem hiding this comment.
There is no explorer url for canton as it's a privacy based chain
baltiyal
reviewed
Oct 1, 2025
modules/statics/src/coinFeatures.ts
Outdated
| CoinFeature.CUSTODY_BITGO_INDIA, | ||
| ]; | ||
|
|
||
| export const CANTON_FEATURES = [...CANTON_DEFAULT_FEATURES, CoinFeature.TSS, CoinFeature.TSS_COLD]; |
There was a problem hiding this comment.
Why created 2 different features arrays?
There was a problem hiding this comment.
Idea was to make the CANTON_DEFAULT_FEATURES as the default feature for utxo coins that is on account model (sui & ada).
Ada maintains its own default features inside ada class - for these we can make a common default feature.
Have added a ticket in backlog: COIN-5870
For now will make a single features array for canton
baltiyal
reviewed
Oct 1, 2025
| Networks.main.canton, | ||
| UnderlyingAsset.CANTON, | ||
| CANTON_FEATURES, | ||
| '', |
There was a problem hiding this comment.
if prefix is always empty for both testnet and mainnet coin, then could we remove prefix itself?
ravibitgo
force-pushed
the
COIN-5805
branch
2 times, most recently
from
9f44e16 to
9aa34bb
Compare
ravibitgo
force-pushed
the
COIN-5851
branch
2 times, most recently
from
9c0a398 to
d9763f4
Compare
at31416
reviewed
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: COIN-5851