CRDCDH-3602 Data Submissions List – Use study.dbGaPID instead of root dbGaPID#960
Merged
Alejandro-Vega merged 3 commits into3.6.0from Mar 18, 2026
Merged
CRDCDH-3602 Data Submissions List – Use study.dbGaPID instead of root dbGaPID#960Alejandro-Vega merged 3 commits into3.6.0from
study.dbGaPID instead of root dbGaPID#960Alejandro-Vega merged 3 commits into3.6.0from
Conversation
#420 Bundle Size — 12.29MiB (~+0.01%).960d0e2(current) vs 7804c52 3.6.0#419(baseline) Warning Bundle contains 50 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch CRDCDH-3602 Project dashboard Generated by RelativeCI Documentation Report issue |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates dbGaPID usage in the data submissions list from the submission top-level field to the nested study.dbGaPID, while marking the top-level dbGaPID as deprecated in the shared Submission type.
Changes:
- Extend
Submission.studyto includedbGaPID, and deprecate the top-levelSubmission.dbGaPIDfield. - Update the
listSubmissionsGraphQL query to fetchstudy.dbGaPIDinstead of the top-leveldbGaPID. - Update the Data Submissions list table column to display/sort/export using
study.dbGaPID.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/types/Submissions.d.ts | Adds dbGaPID to Submission.study and deprecates top-level dbGaPID. |
| src/graphql/listSubmissions.ts | Moves dbGaPID selection under study in the query. |
| src/content/dataSubmissions/DataSubmissionsListView.tsx | Switches the “dbGaP ID” column to use study.dbGaPID for rendering/sorting/export. |
You can also share your feedback on Copilot code review. Take the survey.
Alejandro-Vega
approved these changes
Mar 18, 2026
Contributor
Alejandro-Vega
left a comment
There was a problem hiding this comment.
LGTM! Everything still seems to be working with the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses a request from the BE team to use
study.dbGaPIDinstead ofsubmission.dbGaPID, sincestudy.dbGaPIDis used for the filters. Technically they should always be identicalChange Details (Specifics)
Related Ticket(s)
CRDCDH-3602 (Task)