Skip to content

CRDCDH-3602 Data Submissions List – Use study.dbGaPID instead of root dbGaPID#960

Merged
Alejandro-Vega merged 3 commits into3.6.0from
CRDCDH-3602
Mar 18, 2026
Merged

CRDCDH-3602 Data Submissions List – Use study.dbGaPID instead of root dbGaPID#960
Alejandro-Vega merged 3 commits into3.6.0from
CRDCDH-3602

Conversation

@amattu2
Copy link
Contributor

@amattu2 amattu2 commented Mar 12, 2026

Overview

This PR addresses a request from the BE team to use study.dbGaPID instead of submission.dbGaPID, since study.dbGaPID is used for the filters. Technically they should always be identical

Change Details (Specifics)

  • Switch the Data Submission List view from reading the root dbGaPID object to the nested study dbGaPID
  • Mark the root dbGaPID property as deprecated – It's still technically populated though

Related Ticket(s)

CRDCDH-3602 (Task)

Copilot AI review requested due to automatic review settings March 12, 2026 15:02
@relativeci
Copy link

relativeci bot commented Mar 12, 2026

#420 Bundle Size — 12.29MiB (~+0.01%).

960d0e2(current) vs 7804c52 3.6.0#419(baseline)

Warning

Bundle contains 50 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#420
     Baseline
#419
Regression  Initial JS 874.56KiB(~+0.01%) 874.56KiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 6.12% 6.87%
No change  Chunks 58 58
No change  Assets 101 101
No change  Modules 8891 8891
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 272 272
No change  Duplicate Packages 49 49
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#420
     Baseline
#419
Regression  JS 9.77MiB (~+0.01%) 9.77MiB
No change  IMG 1.72MiB 1.72MiB
No change  Fonts 805.07KiB 805.07KiB
No change  CSS 18KiB 18KiB

Bundle analysis reportBranch CRDCDH-3602Project dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates dbGaPID usage in the data submissions list from the submission top-level field to the nested study.dbGaPID, while marking the top-level dbGaPID as deprecated in the shared Submission type.

Changes:

  • Extend Submission.study to include dbGaPID, and deprecate the top-level Submission.dbGaPID field.
  • Update the listSubmissions GraphQL query to fetch study.dbGaPID instead of the top-level dbGaPID.
  • Update the Data Submissions list table column to display/sort/export using study.dbGaPID.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/types/Submissions.d.ts Adds dbGaPID to Submission.study and deprecates top-level dbGaPID.
src/graphql/listSubmissions.ts Moves dbGaPID selection under study in the query.
src/content/dataSubmissions/DataSubmissionsListView.tsx Switches the “dbGaP ID” column to use study.dbGaPID for rendering/sorting/export.

You can also share your feedback on Copilot code review. Take the survey.

@amattu2 amattu2 added this to the 3.6.0 milestone Mar 12, 2026
@amattu2 amattu2 requested a review from Alejandro-Vega March 12, 2026 15:17
Copy link
Contributor

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Everything still seems to be working with the change.

@Alejandro-Vega Alejandro-Vega merged commit 4371b31 into 3.6.0 Mar 18, 2026
9 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-3602 branch March 18, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants