Skip to content

CRDCDH-3602 Data Submissions List – Use study.dbGaPID instead of root dbGaPID #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alejandro-Vega merged 3 commits into from
Mar 18, 2026
Merged

CRDCDH-3602 Data Submissions List – Use study.dbGaPID instead of root dbGaPID #960

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7108992
Use `study`.`dbGaPID` instead of root `dbGaPID`
amattu2 Mar 12, 2026
fd0c1a2
fix: Outdated response typing
amattu2 Mar 12, 2026
960d0e2
Merge branch '3.6.0' into CRDCDH-3602
amattu2 Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/content/dataSubmissions/DataSubmissionsListView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,10 @@ const columns: Column<T>[] = [
},
{
label: "dbGaP ID",
renderValue: (a) => <TruncatedText text={a.dbGaPID} maxCharacters={15} />,
field: "dbGaPID",
renderValue: (a) => <TruncatedText text={a?.study?.dbGaPID} maxCharacters={15} />,
fieldKey: "study.dbGaPID",
hideable: true,
exportValue: (a) => ({ label: "dbGaP ID", value: a.dbGaPID }),
exportValue: (a) => ({ label: "dbGaP ID", value: a.study?.dbGaPID || "" }),
},

{
Expand Down
2 changes: 1 addition & 1 deletion src/graphql/listSubmissions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ export const query: TypedDocumentNode<Response, Input> = gql`
study {
studyName
studyAbbreviation
dbGaPID
}
dbGaPID
modelVersion
status
archived
Expand Down
9 changes: 7 additions & 2 deletions src/types/Submissions.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,13 @@ type Submission = {
/**
* The study associated with the submission.
*/
study: Pick<ApprovedStudy, "studyName" | "studyAbbreviation">;
dbGaPID: string; // # aka. phs number
study: Pick<ApprovedStudy, "studyName" | "studyAbbreviation" | "dbGaPID">;
/**
* The dbGaP PHS Accession number associated with the submission's study.
*
* @deprecated Use `study.dbGaPID` instead.
*/
dbGaPID: string;
bucketName: string; // # populated from organization
rootPath: string; // # a submission folder will be created under this path, default is / or "" meaning root folder
status: SubmissionStatus;
Expand Down
Loading