forked from spraakbanken/korp-frontend
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration: Add Cuneiform corpora Achemenet and BALT #14
Merged
+275
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontend into corp-oracc2021
Merge Achemenet definitions from old (5.0.10-based) branch corp-achemenet into config/achemenet based on the current config/master. The configuration is yet to be converted to Korp 9. Technically, corp-achemenet was first merged into config/achemenet with strategy "ours" and the merge commit was then amended with the relevant changes, to avoid major merge conflicts. * origin/corp-achemenet: achemenet fix achement beta
(Committed by Jyrki Niemi on behalf of Aleksi Sahala.)
Achemenet: - Move corpus definitions after those of Oracc 2021, as they use the attribute lists for Oracc 2021.
Achemenet: - Rename subcorpora: YOS -> YOS 7, Jursa -> Bel-remanni, CT -> CT 55, and similarly the corpus ids.
app/modes/other_languages_mode.js: - attrlist.oracc2021.url: Change the label to "link_to_original", so that it is logical also in Achemenet.
Achemenet: Add correct URNs for location, metadata and info page (resource group page), with the latter two commented out, waiting for the actual pages to be created.
Update config/achemenet with changes made to config/master. * config/master: (74 commits) Syntax fix Remove defunct links to the korp.csc.fi domain Point links away from defunct Annlab Rename korpBackendServer to kielipankkiBaseAddress KP-9173 Actually set the value of korpBackendURL! KP-9173 Use the backend of this particular instance KP-9048 Update reittidemo video path Rename ignore_between_tokens_cqp -> ignoreBetweenTokensCQP Oracc 2021: Description: Add link to the list of texts ScotsCorr: Fix label for text_scripttype2 ScotsCorr: Widen token box with word list and dict links ScotsCorr word list: Add English and Swedish translations ScotsCorr word list: Adjust list style ScotsCorr word list: Scroll words only, not heading ScotsCorr: Add word list modal styles custom/extended.js: scotscorrWord: Fix selecting words custom/extended.js: scotscorrWord: Define func s.inputChange custom/extended.js: scotscorrWord: var -> let/const custom/extended.js: scotscorrWord: Use template literals custom/extended.js: scotscorrWord: Fix subtree icons ...
app/modes/other_languages_mode.js - Achemenet: - Add a longer corpus description. - Uncomment metadata URN. - Update licence info to use CC BY 4.0 and to link to corpus-specific licence URN. - Adjust IPR holder name. - Reformat "contents" to list one corpus per line.
app/modes/other_languages_mode.js: - Achemenet: Update structural attributes: add those not in Oracc 2021 (text_cdilink, text_date, text_archive, text_id, sentence_translation, sentence_id) and remove those in Oracc 2021 but not in Achemenet (text_photo, text_copy, text_accessionno, text_excavation). app/translations/corpora-en.json, app/translations/corpora-fi.json: - Add translations for "cdli_link" and "archive".
app/modes/other_languages_mode.js: - Achemenet: Remove structural attributes text_collection (in Oracc 2021 but not in Achemenet) and sentence_translation (was removed from the data).
app/modes/other_languages_mode.js: - Achemenet: Replace positional attribute url with structural attribute text_url ("link to original").
app/modes/other_languages_mode.js: - Fix to remove structural attributes text_url and text_empty from BALT, not Achemenet, as was incorrectly done.
Update config/achemenet with changes made to config/master, to be used in the configuration of Achemenet and/or BALT. * config/master: modes/common.js: funcs.addCorpusSettings: Support multiple {} modes/common.js: funcs.addCorpusSettings: Modernize code modes/common.js: funcs.setAttrOrder: Test if attr exists modes/common.js: funcs.setAttrOrder: Modernize code
app/modes/other_languages_mode.js: - Achemenet: Modify as suggested by Tero Alstola: - Description: Add link to a publication with more information. - Subcorpus descriptions: Add information on the original publications. - Edit the title of achemenet_belremanni. - Order subcorpora alphabetically.
app/modes/other_languages_mode.js: - BALT: Modify as suggested by Tero Alstola: - Description: Add link to a publication with more information. - Add University of Helsinki as the IPR holder. - Subcorpus descriptions: Add information on the original publications. - Modify the titles of subcorpora to refer to the original publication.
app/modes/other_languages_mode.js: - Achemenet and BALT: Use the same order for attributes (both positional and structural).
mmatthiesencsc
approved these changes
Mar 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jyrki, sorry for being slow with this. I tried "ana" and noticed that the cldi links do not work. Not really our problem, but if the server is down, maybe we should not provide them?
Not much to add, approving.
CLDI started working again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the configuration for two Cuneiform corpora:
The configuration is in use in this Korp test instance.