chore(Billboards): Add deprecation notice for legacy WebGL fallbacks #13067
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request, @donmccurdy! ✅ We can confirm we have a CLA on file for you. |
donmccurdy
force-pushed
the
chore/deprecation-billboard-legacy-webgl-fallbacks
branch
from
5e6e576 to
5a2ef8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a deprecation notice when billboards are shown on devices that don't support WebGL 2 or WebGL 1 with ANGLE_instanced_arrays and MAX_VERTEX_TEXTURE_IMAGE_UNITS > 0. Fallback support for rendering billboards and labels on devices without these features will be removed in Cesium 1.140.
Issue number and link
For further details and feedback, see:
Testing plan
n/a
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my changeI have added or updated unit tests to ensure consistent code coverageI have updated the inline documentation, and included code examples where relevantPR Dependency Tree
This tree was auto-generated by Charcoal