Skip to content

chore(Billboards): Add deprecation notice for legacy WebGL fallbacks #13067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −0
Open

chore(Billboards): Add deprecation notice for legacy WebGL fallbacks #13067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Change Log

## 1.137

### @cesium/engine

#### Deprecated :hourglass_flowing_sand:

- Beginning in CesiumJS 1.140, billboards and labels will require device support for WebGL 2, or WebGL 1 with ANGLE_instanced_arrays and MAX_VERTEX_TEXTURE_IMAGE_UNITS > 0. For more information or to share feedback, please see [#13053](https://github.com/CesiumGS/cesium/issues/13053). [#13067](https://github.com/CesiumGS/cesium/issues/13067)

## 1.136 - 2025-12-01

### @cesium/engine
Expand Down
14 changes: 14 additions & 0 deletions packages/engine/Source/Scene/BillboardCollection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import TextureAtlas from "../Renderer/TextureAtlas.js";
import VerticalOrigin from "./VerticalOrigin.js";
import Ellipsoid from "../Core/Ellipsoid.js";
import WebGLConstants from "../Core/WebGLConstants.js";
import deprecationWarning from "../Core/deprecationWarning.js";

const SHOW_INDEX = Billboard.SHOW_INDEX;
const POSITION_INDEX = Billboard.POSITION_INDEX;
Expand Down Expand Up @@ -1784,6 +1785,19 @@ BillboardCollection.prototype.update = function (frameState) {
}

const context = frameState.context;

if (
!context.instancedArrays ||
!(ContextLimits.maximumVertexTextureImageUnits > 0)
) {
deprecationWarning(
"Billboard-unsupported-ANGLE_instanced_arrays",
"Beginning in CesiumJS 1.140, billboards and labels will require device support for WebGL 2, " +
"or WebGL 1 with ANGLE_instanced_arrays and MAX_VERTEX_TEXTURE_IMAGE_UNITS > 0. For more " +
"information or to share feedback, see: https://github.com/CesiumGS/cesium/issues/13053",
);
}

this._instanced = context.instancedArrays;
attributeLocations = this._instanced
? attributeLocationsInstanced
Expand Down
Loading