Switch playwright over to the new sandcastle#13381
Conversation
|
Thank you for the pull request, @jjspace! ✅ We can confirm we have a CLA on file for you. |
|
@jjspace I still get this: |
I tried adding these troubleshooting steps shared with me during the last release to the testing guide I believe these apply to you @jjhembd as well using Linux Chrome. |
|
@lukemckinstry I get the same result with that config. |
lukemckinstry
left a comment
lukemckinstry
left a comment
There was a problem hiding this comment.
The e2e tests generate correctly. A few questions and suggestions.
| - `--project="webkit"` - Test only webkit. Can also use `chromium` or `firefox` to test against those browsers. | ||
| - `-g <grep>` or `--grep <grep>` - Run only tests that match a regular expression. | ||
| - `--grep-invert <grep>` - Run only tests that don't match a regular expression. | ||
| - `--ui` - Launch a test browser to view and run specific tests. Note it's not perfect with dynamic canvases but it's still helpful |
There was a problem hiding this comment.
npx playwright test -c Specs/e2e/playwright.config.js --project=chromium --ui seems to be a blank controller for me
There was a problem hiding this comment.
You need to click the Play triangle on a test to run them, individually or a whole nested section in the tree on the left.
| name: "chromium", | ||
| use: { | ||
| ...devices["Desktop Chrome"], | ||
| channel: "chromium", |
There was a problem hiding this comment.
I had to set this to chrome (in addition to swapping in args: ["--use-angle=vulkan"], for args: ["--use-angle=gl"], for the tests to generate correctly
There was a problem hiding this comment.
We want this to be chromium for the new headless mode. If that's not working for you for some reason we should track down why
| // Check if hardware acceleration is enabled. Without it, our tests will be much slower. | ||
| test("GPU hardware acceleration", async ({ page }) => { | ||
| await page.goto(chromeGpu); | ||
| test("Hardware accelleration check - Chrome", async ({ page }, testInfo) => { |
There was a problem hiding this comment.
Are these changes tied to the playwright update?
There was a problem hiding this comment.
this is just an updated version of this helper script that can be used to debug the playwright setup itself
lukemckinstry
left a comment
lukemckinstry
left a comment
There was a problem hiding this comment.
Looks good and works as expected 👍
3 participants
Description
Switches the sandcastle e2e tests over to use the new Sandcastle's standalone page.
There is still a potential for inconsistencies between test runs or on different systems. There's many more things we could probably do to improve the e2e tests overall but that was beyond the scope of this PR. If cused only on switching to the new Sandcastle and gallery which is the only remaining blocker for removing the legacy sandcastle
Issue number and link
Part of #12894
Testing plan
npm run test-e2eand make sure the sandcastle tests are running and (hopefully) passingnpm run test-e2e-updateto generate snapshots if you don't already have some savednpx playwright test -c Specs/e2e/playwright.config.js --project=chromium --uito have a more interactiveAuthor checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my changeAI acknowledgment
If yes, I used the following Tools(s) and/or Service(s):
If yes, I used the following Model(s):