CLI improvements #41
Merged
CLI improvements #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fetching additional resources reserved in a lease, such as hosts, networks, and devices command to accept a new --detail flag, enabling users to request all resources reserved in a lease * Parallelize calls to get allocations in lease detail get Parallelize the calls to hosts_in_lease, networks_in_lease, and devices_in_lease using Python's concurrent.futures module. By submitting these calls to a thread pool for concurrent execution and retrieving the results once the tasks are completed, the performance of the get method is potentially improved.
Updated the `UpdateCapabilityCommand` in the blazar client to include a new `--unique` flag, allowing users to set a capability as unique when updating or creating a capability. Also, modified the `set_capability` method in the `ComputeHostClientManager` to include the `is_unique` parameter when sending a PATCH request to update the capability. This enhancement enables users to specify whether a capability should be unique or not via the blazar client.
* Fix 'detail' parameter usage in Blazar client show command This commit fixes the handling of the 'detail' parameter in the Blazar client show command. Since other resources like hosts and FIPs do not have a detail keyword in their manager get method, the previous implementation caused errors. This commit removes the unnecessary usage of 'detail' and instead calls the 'additional_details' method if the parsed args have 'detail' arg to fetch additional details Additionally, tests are added to cover the corrected behavior of the show command with and without the 'detail' parameter. * Add github actions to run unittests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bug fixes with formatting.
Add --long flag for listing, and add filter flags for leases, hosts.
Add in features accidentally dropped during antelope upgrade.