-
Notifications
You must be signed in to change notification settings - Fork 349
feat(query): implements "Beta - SQL DB Instance Without Centralized Logging" #7785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…re_that_'cloudsql.enable_pgaudit'_database_flag_for_each_cloud_sql_postgresql_instance_is_set_to_on_for_centralized_logging
…16629_16_6.2_PostgreSQL_Database_ensure_that_'cloudsql.enable_pgaudit'_database_flag_for_each_cloud_sql_postgresql_instance_is_set_to_on_for_centralized_logging
cx-artur-ribeiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice job!
…re_that_'cloudsql.enable_pgaudit'_database_flag_for_each_cloud_sql_postgresql_instance_is_set_to_on_for_centralized_logging
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 21271469 | Triggered | Generic Password | cf16128 | assets/queries/terraform/azure/unrestricted_sql_server_access/test/negative6.tf | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.








Reason for Proposed Changes
Currently there is no query to ensure that a "google_sql_database_instance" resource with a "POSTGRES" based "database_version" has the 'cloudsql.enable_pgaudit' flag enabled.
Quoting CIS_Google_Cloud_Platform_Foundation_Benchmark_v4.0.0 page 238: "
As numerous other recommendations in this section consist of turning on flags for logging purposes, your organization will need a way to manage these logs. You may have a solution already in place. If you do not, consider installing and enabling the open source pgaudit extension within PostgreSQL and enabling its corresponding flag of cloudsql.enable_pgaudit. This flag and installing the extension enables database auditing in PostgreSQL through the open-source pgAudit extension. This extension provides detailed session and object logging to comply with government, financial, & ISO standards and provides auditing capabilities to mitigate threats by monitoring security events on the instance."Proposed Changes
Implemented the missing query.
The query will flag for 4 separate instances : (all after ensuring "database_version" is POSTGRES based (possible values list))
Tenable reference
I submit this contribution under the Apache-2.0 license.