[02/09] audio: capture lifecycle fix + ALSA stderr suppression #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
Comment on lines
48
to
+53
| impl AudioCaptureThread { | ||
| pub fn spawn( | ||
| config: AudioConfig, | ||
| audio_producer: AudioProducer, | ||
| audio_producer: Arc<Mutex<AudioProducer>>, | ||
| device_name: Option<String>, | ||
| enable_device_monitor: bool, |
There was a problem hiding this comment.
The spawn signature now requires an Arc<Mutex<AudioProducer>> and an enable_device_monitor flag. Callers across the workspace still invoke AudioCaptureThread::spawn with the old three-argument form and pass a bare AudioProducer (see crates/app/src/probes/mic_capture.rs, crates/app/src/probes/vad_mic.rs, crates/app/src/runtime.rs, and examples/device_hotplug_demo.rs). With this change the project no longer compiles because those call sites cannot satisfy the new parameter list or type. Either provide a backward-compatible wrapper or update all uses in the same change.
Useful? React with 👍 / 👎.
Comment on lines
+1
to
+6
| /// Utility to temporarily suppress stderr output from ALSA/CPAL library calls | ||
| /// that produce noisy warnings about missing PCM plugins (pulse, jack, oss, etc.) | ||
| use std::fs::File; | ||
| use std::io; | ||
| use std::os::unix::io::{AsRawFd, FromRawFd}; | ||
|
|
There was a problem hiding this comment.
The new stderr suppressor module relies on std::os::unix::io and hardcodes /dev/null. Because DeviceManager now calls StderrSuppressor::with_suppressed unconditionally, building the crate on non‑Unix targets (e.g. Windows) will fail to compile – those APIs and paths do not exist there. If Windows or other non‑Unix builds are supported, the implementation needs to be #[cfg(unix)] or provide a platform-specific fallback.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull Request Overview
Part 2/9 focuses on stabilizing audio capture lifecycle and reducing ALSA stderr noise by suppressing noisy CPAL/ALSA warnings, plus related logging and test adjustments.
- Introduces stderr suppression around CPAL calls and adds device enumeration caching.
- Fixes capture thread lifecycle and makes device monitoring optional/configurable.
- Adjusts logging levels and test harness to match new capture API.
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/coldvox-audio/tests/device_hotplug_tests.rs | Updates tests to wrap ring buffer producer in Arc and use new spawn signature. |
| crates/coldvox-audio/tests/default_mic_detection_it.rs | Same test update; minor parsing simplifications. |
| crates/coldvox-audio/src/stderr_suppressor.rs | Adds RAII-based stderr redirection to /dev/null. |
| crates/coldvox-audio/src/monitor.rs | Debounces device removal with missing_count and quieter stop logging. |
| crates/coldvox-audio/src/lib.rs | Exposes new stderr_suppressor module. |
| crates/coldvox-audio/src/device.rs | Uses StderrSuppressor around CPAL calls; adds device cache with TTL. |
| crates/coldvox-audio/src/detector.rs | Adds per-frame trace logging and elevates silence transitions to info. |
| crates/coldvox-audio/src/capture.rs | Changes capture API: producer now Arc, optional device monitor, lifecycle fix. |
| crates/coldvox-audio/plugins.json | Adds a plugin configuration JSON (STT-oriented). |
| crates/coldvox-audio/docs/design-user-config.md | Minor config doc adjustments. |
| crates/coldvox-audio/Cargo.toml | Adds libc dependency for stderr suppression. |
| crates/app/src/audio/vad_processor.rs | Lowers VAD start/end logs to debug and uses a modulus helper. |
| crates/app/src/audio/mod.rs | Reorganizes audio module; removes previous re-exports and adds wav loader module. |
| fn test_audio_capture_thread_with_device_events() { | ||
| let buffer = AudioRingBuffer::new(8192); | ||
| let (producer, _consumer) = buffer.split(); | ||
| let producer = Arc::new(Mutex::new(producer)); |
There was a problem hiding this comment.
AudioCaptureThread::spawn now expects Arc<std::sync::Mutex>, but the test passes Arc<parking_lot::Mutex<_>>, which is a different type and will not compile. Switch the test to use std::sync::Mutex (or change the spawn signature to accept parking_lot::Mutex consistently).
|
|
||
| let rb = AudioRingBuffer::new(16384); | ||
| let (producer, mut consumer) = rb.split(); | ||
| let producer = Arc::new(Mutex::new(producer)); |
There was a problem hiding this comment.
Same mismatch as above: Arc<parking_lot::Mutex<>> is not compatible with Arc<std::sync::Mutex<>> expected by AudioCaptureThread::spawn. Use std::sync::Mutex in the test or align the production signature to parking_lot::Mutex.
Comment on lines
+129
to
+136
| if self.frames_processed.is_multiple_of(100) { | ||
| tracing::debug!( | ||
| "VAD: Received {} frames, processing active", | ||
| self.frames_processed | ||
| ); | ||
| } | ||
|
|
||
| if self.frames_processed % 1000 == 0 { | ||
| if self.frames_processed.is_multiple_of(1000) { |
There was a problem hiding this comment.
Primitive integers do not have is_multiple_of in stable Rust; this will not compile. Use a modulo check instead: self.frames_processed % 100 == 0.
| } | ||
|
|
||
| if self.frames_processed % 1000 == 0 { | ||
| if self.frames_processed.is_multiple_of(1000) { |
There was a problem hiding this comment.
Same issue: replace with self.frames_processed % 1000 == 0 for stable Rust compatibility.
Suggested change
| if self.frames_processed.is_multiple_of(1000) { | |
| if self.frames_processed % 1000 == 0 { |
| /// that produce noisy warnings about missing PCM plugins (pulse, jack, oss, etc.) | ||
| use std::fs::File; | ||
| use std::io; | ||
| use std::os::unix::io::{AsRawFd, FromRawFd}; |
There was a problem hiding this comment.
This module is Unix-only but is compiled unconditionally, which will break non-Unix builds (e.g., Windows). Gate the module with cfg(unix) and provide a no-op fallback for non-Unix targets.
Comment on lines
8
to
9
| pub mod ring_buffer; | ||
| pub mod stderr_suppressor; |
There was a problem hiding this comment.
The stderr_suppressor module is Unix-specific; exposing it unconditionally will cause build failures on non-Unix platforms. Wrap with cfg(unix), and add a non-Unix shim module that provides StderrSuppressor::with_suppressed as a pass-through.
Suggested change
| pub mod ring_buffer; | |
| pub mod stderr_suppressor; | |
| pub mod ring_buffer; | |
| #[cfg(unix)] | |
| pub mod stderr_suppressor; | |
| #[cfg(not(unix))] | |
| pub mod stderr_suppressor { | |
| /// Shim for non-Unix platforms: does nothing. | |
| pub struct StderrSuppressor; | |
| impl StderrSuppressor { | |
| pub fn with_suppressed<F: FnOnce() -> R, R>(f: F) -> R { | |
| f() | |
| } | |
| } | |
| } |
Comment on lines
+37
to
+43
| pub fn with_suppressed<F, R>(f: F) -> R | ||
| where | ||
| F: FnOnce() -> R, | ||
| { | ||
| match Self::new() { | ||
| Ok(guard) => { | ||
| let result = f(); |
There was a problem hiding this comment.
Redirecting process-wide stderr without synchronization can inadvertently suppress logs from other threads. Serialize usage with a global mutex (e.g., once_cell::sync::Lazy<Mutex<()>>) around with_suppressed to ensure only one suppression window is active at a time.
Comment on lines
+27
to
+32
| tracing::trace!( | ||
| "SilenceDetector: RMS={}, threshold={}, samples={}", | ||
| rms, | ||
| self.threshold, | ||
| samples.len() | ||
| ); |
There was a problem hiding this comment.
Emitting a trace event per frame can add significant overhead in a 512-sample/16 kHz pipeline even when filtered. Consider sampling these logs (e.g., every N frames) or gating behind a feature flag to avoid hot-path overhead.
Comment on lines
+37
to
40
| tracing::info!( | ||
| "SilenceDetector: Silence started (RMS {} < threshold {})", | ||
| rms, | ||
| self.threshold |
There was a problem hiding this comment.
Promoting state transition logs to info will spam logs during normal operation; prefer debug for these frequent events to keep default logs clean.
Comment on lines
49
to
54
| pub fn spawn( | ||
| config: AudioConfig, | ||
| audio_producer: AudioProducer, | ||
| audio_producer: Arc<Mutex<AudioProducer>>, | ||
| device_name: Option<String>, | ||
| enable_device_monitor: bool, | ||
| ) -> Result< |
There was a problem hiding this comment.
This is a breaking change (new parameter and changed type), but the PR claims no breaking audio API changes. To preserve compatibility, consider keeping the original signature and adding a new constructor (e.g., spawn_with_monitor) or accept AudioProducer by value and wrap it internally (Arc<Mutex<...>>), defaulting enable_device_monitor to true.
This was referenced Oct 8, 2025
Owner
Author
|
Circular Dependency Issue Detected This PR (#124) declares `pub mod wav_file_loader;` in `crates/app/src/audio/mod.rs` but the actual file `wav_file_loader.rs` doesn't exist in this PR - it's in PR #127. This creates a build failure because the module is declared but the file is missing. Request: This will resolve the circular dependency and make this PR independently buildable. Alternatively, should we remove the module declaration from this PR and move it to #127 instead? Posted via gh CLI to coordinate fix without interfering with local workflow |
This was referenced Oct 8, 2025
…124) - Remove wav_file_loader module declaration from app/audio/mod.rs (decouples #124 from #127 dependency) - Remove misplaced STT plugins.json from crates/coldvox-audio/ (STT config belongs in app-level or config/ directory, not audio crate) - Add #[cfg(unix)] guards to stderr_suppressor module and usage (Unix-specific file descriptor operations) - Add comprehensive SAFETY documentation to all unsafe blocks in stderr_suppressor.rs explaining FD ownership and dup2 atomicity Note: coldvox-audio compiles and tests pass. coldvox-app has pre-existing API signature mismatches (AudioCaptureThread::spawn) that need separate fix. Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Coldaine
added a commit
that referenced
this pull request
Oct 8, 2025
* [08/09] logs: prune noisy hot paths; telemetry tweaks * fix: replace hardcoded device with env var and fallback chain - Use COLDVOX_TEST_DEVICE env var if set - Fall back to ctx.device from test context - Fall back to default device detection if neither specified - Improves portability across different hardware setups 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * fix(logging): remove hardcoded device; add env/ctx fallback (#130) - Replace hardcoded "HyperX QuadCast" device in vad_mic.rs with flexible fallback: 1. Check COLDVOX_TEST_DEVICE env var first 2. Fall back to TestContext.device 3. Use None for default enumeration if neither specified - Add warning log when falling back to default enumeration - Add TODO(#130) comment for misnamed counter `requests_per_second` → `total_requests` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * [01/09] config: centralize Settings + path-aware load (#123) * [01/09] config: centralize Settings + path-aware load * Add config dependency and lib section to Cargo.toml * Update Cargo.lock for config dependency * fix(ci): resolve Vosk setup issues for self-hosted runner - Fix cache path mismatch: script now checks alternate cache locations (/vosk-models vs /vosk) with fallback logic - Switch to large production model: vosk-model-en-us-0.22 (1.8GB) - Update model checksum to match current alphacephei.com version - Add libvosk fallback: checks cache, alternate cache, and system paths - Make GITHUB_OUTPUT optional for local testing - Add comprehensive test suite: test_vosk_setup.sh mimics CI workflow - Add detailed verification report: VOSK_SETUP_VERIFICATION.md Resolves model download and linking failures in CI workflows. All verification tests pass locally on self-hosted runner. Tested: - Setup script execution (symlinks created correctly) - Build: cargo build -p coldvox-stt-vosk --features vosk ✅ - Unit tests: 3/3 passed ✅ - Model structure validation ✅ * debugging * Add build.rs to link vendored libvosk at compile time Fixes linker error 'unable to find library -lvosk' by: - Adding vendor/vosk/lib to rustc link search path - Setting rpath for runtime library discovery - Falling back to system paths (/usr/local/lib, /usr/lib64, /usr/lib) - Using cargo:rerun-if-changed for efficient rebuilds Addresses issue documented in docs/dev/THE_MISSING_LINK.md. Follows Rust best practices per Cargo book build script guidelines. Tested with: cargo check -p coldvox-stt-vosk --features vosk * fix: Update main.rs to match runtime struct definitions - Remove non-existent 'enable_device_monitor' field from AppRuntimeOptions - Update InjectionOptions initialization to match actual struct fields - Add missing 'allow_ydotool' and 'restore_clipboard' fields This fixes compilation errors when building coldvox-app with vosk features. * chore: retrigger CI after runner restart * test: trigger CI after fixing Rust version * docs: Add comprehensive self-hosted runner management architecture Create complete runnerAgent documentation system for managing and optimizing the self-hosted GitHub Actions runner (laptop-extra). Structure: - README.md: Quick start guide with daily workflows and debugging commands - RunnerAgent.md: Complete architecture document with system design - IMPLEMENTATION.md: Usage patterns, integration guide, and next steps - prompts/: LLM assistant configurations for specialized tasks - debug_agent_prompt.md: CI failure diagnosis workflows - system_update_prompt.md: Dependency and toolchain maintenance - performance_monitor_prompt.md: Build/test optimization strategies Key features: - Executable commands for common operations (health checks, log analysis) - LLM-ready prompts for AI-assisted debugging with tools like gemini CLI - Local-first approach leveraging direct hardware access - Performance monitoring and optimization guidelines - Integration with existing CI workflows and scripts Benefits: - Self-service debugging without admin access - Faster iteration (test locally before pushing) - Performance visibility and tracking - Reproducible maintenance workflows Related: PR #123 (requires runner toolchain update to pass CI) * docs(runnerAgent): include absolute runner workspace path /home/coldaine/actions-runner/_work/ColdVox/ColdVox in key docs * docs(runnerAgent): add gemini-based runner debugger script and README note --------- Co-authored-by: ColdVox Dev <[email protected]> Co-authored-by: Coldaine <[email protected]> * [02/09] audio: capture lifecycle fix + ALSA stderr suppression (#124) * [01/09] config: centralize Settings + path-aware load * Add config dependency and lib section to Cargo.toml * Update Cargo.lock for config dependency * [02/09] audio: capture lifecycle fix + ALSA stderr suppression * fix(audio): decouple wav_file_loader decl, cfg(unix) + safety notes (#124) - Remove wav_file_loader module declaration from app/audio/mod.rs (decouples #124 from #127 dependency) - Remove misplaced STT plugins.json from crates/coldvox-audio/ (STT config belongs in app-level or config/ directory, not audio crate) - Add #[cfg(unix)] guards to stderr_suppressor module and usage (Unix-specific file descriptor operations) - Add comprehensive SAFETY documentation to all unsafe blocks in stderr_suppressor.rs explaining FD ownership and dup2 atomicity Note: coldvox-audio compiles and tests pass. coldvox-app has pre-existing API signature mismatches (AudioCaptureThread::spawn) that need separate fix. Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: ColdVox Dev <[email protected]> Co-authored-by: Claude <[email protected]> * [03/09] vad: windowing/debounce consistency (#125) * [01/09] config: centralize Settings + path-aware load * Add config dependency and lib section to Cargo.toml * Update Cargo.lock for config dependency * [02/09] audio: capture lifecycle fix + ALSA stderr suppression * [03/09] vad: windowing/debounce consistency --------- Co-authored-by: ColdVox Dev <[email protected]> * [04/09] stt: finalize handling + helpers (#126) * [01/09] config: centralize Settings + path-aware load * Add config dependency and lib section to Cargo.toml * Update Cargo.lock for config dependency * [02/09] audio: capture lifecycle fix + ALSA stderr suppression * [03/09] vad: windowing/debounce consistency * [04/09] stt: finalize handling + helpers * fix: add constants module declaration to coldvox-stt - Declare pub mod constants in lib.rs - Note: helpers.rs not declared due to circular dependency with coldvox-telemetry - helpers.rs is currently unused and can be integrated when telemetry refactor resolves cycle 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * fix(stt): add module decls, clean imports, constants (#126) - Add constants module declaration to lib.rs - Move SttMetrics from processor.rs to types.rs (breaks circular dependency) - Clean imports in helpers.rs (remove circular import, alphabetize) - Replace magic numbers in processor.rs with named constants: - 16000 -> SAMPLE_RATE_HZ - 10 -> DEFAULT_BUFFER_DURATION_SECONDS - 100 -> LOGGING_INTERVAL_FRAMES - 5 -> SEND_TIMEOUT_SECONDS - Comment out helpers module (requires coldvox_telemetry, should move to app crate) Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: ColdVox Dev <[email protected]> Co-authored-by: Claude <[email protected]> --------- Co-authored-by: ColdVox Dev <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: Coldaine <[email protected]>
Coldaine
added a commit
that referenced
this pull request
Oct 8, 2025
* [01/09] config: centralize Settings + path-aware load * Add config dependency and lib section to Cargo.toml * Update Cargo.lock for config dependency * [02/09] audio: capture lifecycle fix + ALSA stderr suppression * [03/09] vad: windowing/debounce consistency * [04/09] stt: finalize handling + helpers * [05/09] app: unify VAD↔STT runtime + real WAV loader * [06/09] injection: clipboard-preserve + Wayland-first strategy * [07/09] tests: deterministic E2E + integration suites * fix: convert clipboard injector test to tokio::test - Replace futures::executor::block_on with async/await - Use #[tokio::test] instead of #[test] for async test - Eliminates need for futures crate dependency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * fix: resolve compilation failures from missing .await Add .await to async StrategyManager::new() calls in integration tests. StrategyManager::new() is an async function that returns a Future, which must be awaited. Fixed 3 occurrences in: - text_injection_integration_test.rs (lines 55, 90, 119) * [08/09] logs: prune noisy hot paths; telemetry tweaks (#130) * [08/09] logs: prune noisy hot paths; telemetry tweaks * fix: replace hardcoded device with env var and fallback chain - Use COLDVOX_TEST_DEVICE env var if set - Fall back to ctx.device from test context - Fall back to default device detection if neither specified - Improves portability across different hardware setups 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * fix(logging): remove hardcoded device; add env/ctx fallback (#130) - Replace hardcoded "HyperX QuadCast" device in vad_mic.rs with flexible fallback: 1. Check COLDVOX_TEST_DEVICE env var first 2. Fall back to TestContext.device 3. Use None for default enumeration if neither specified - Add warning log when falling back to default enumeration - Add TODO(#130) comment for misnamed counter `requests_per_second` → `total_requests` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * [01/09] config: centralize Settings + path-aware load (#123) * [01/09] config: centralize Settings + path-aware load * Add config dependency and lib section to Cargo.toml * Update Cargo.lock for config dependency * fix(ci): resolve Vosk setup issues for self-hosted runner - Fix cache path mismatch: script now checks alternate cache locations (/vosk-models vs /vosk) with fallback logic - Switch to large production model: vosk-model-en-us-0.22 (1.8GB) - Update model checksum to match current alphacephei.com version - Add libvosk fallback: checks cache, alternate cache, and system paths - Make GITHUB_OUTPUT optional for local testing - Add comprehensive test suite: test_vosk_setup.sh mimics CI workflow - Add detailed verification report: VOSK_SETUP_VERIFICATION.md Resolves model download and linking failures in CI workflows. All verification tests pass locally on self-hosted runner. Tested: - Setup script execution (symlinks created correctly) - Build: cargo build -p coldvox-stt-vosk --features vosk ✅ - Unit tests: 3/3 passed ✅ - Model structure validation ✅ * debugging * Add build.rs to link vendored libvosk at compile time Fixes linker error 'unable to find library -lvosk' by: - Adding vendor/vosk/lib to rustc link search path - Setting rpath for runtime library discovery - Falling back to system paths (/usr/local/lib, /usr/lib64, /usr/lib) - Using cargo:rerun-if-changed for efficient rebuilds Addresses issue documented in docs/dev/THE_MISSING_LINK.md. Follows Rust best practices per Cargo book build script guidelines. Tested with: cargo check -p coldvox-stt-vosk --features vosk * fix: Update main.rs to match runtime struct definitions - Remove non-existent 'enable_device_monitor' field from AppRuntimeOptions - Update InjectionOptions initialization to match actual struct fields - Add missing 'allow_ydotool' and 'restore_clipboard' fields This fixes compilation errors when building coldvox-app with vosk features. * chore: retrigger CI after runner restart * test: trigger CI after fixing Rust version * docs: Add comprehensive self-hosted runner management architecture Create complete runnerAgent documentation system for managing and optimizing the self-hosted GitHub Actions runner (laptop-extra). Structure: - README.md: Quick start guide with daily workflows and debugging commands - RunnerAgent.md: Complete architecture document with system design - IMPLEMENTATION.md: Usage patterns, integration guide, and next steps - prompts/: LLM assistant configurations for specialized tasks - debug_agent_prompt.md: CI failure diagnosis workflows - system_update_prompt.md: Dependency and toolchain maintenance - performance_monitor_prompt.md: Build/test optimization strategies Key features: - Executable commands for common operations (health checks, log analysis) - LLM-ready prompts for AI-assisted debugging with tools like gemini CLI - Local-first approach leveraging direct hardware access - Performance monitoring and optimization guidelines - Integration with existing CI workflows and scripts Benefits: - Self-service debugging without admin access - Faster iteration (test locally before pushing) - Performance visibility and tracking - Reproducible maintenance workflows Related: PR #123 (requires runner toolchain update to pass CI) * docs(runnerAgent): include absolute runner workspace path /home/coldaine/actions-runner/_work/ColdVox/ColdVox in key docs * docs(runnerAgent): add gemini-based runner debugger script and README note --------- Co-authored-by: ColdVox Dev <[email protected]> Co-authored-by: Coldaine <[email protected]> * [02/09] audio: capture lifecycle fix + ALSA stderr suppression (#124) * [01/09] config: centralize Settings + path-aware load * Add config dependency and lib section to Cargo.toml * Update Cargo.lock for config dependency * [02/09] audio: capture lifecycle fix + ALSA stderr suppression * fix(audio): decouple wav_file_loader decl, cfg(unix) + safety notes (#124) - Remove wav_file_loader module declaration from app/audio/mod.rs (decouples #124 from #127 dependency) - Remove misplaced STT plugins.json from crates/coldvox-audio/ (STT config belongs in app-level or config/ directory, not audio crate) - Add #[cfg(unix)] guards to stderr_suppressor module and usage (Unix-specific file descriptor operations) - Add comprehensive SAFETY documentation to all unsafe blocks in stderr_suppressor.rs explaining FD ownership and dup2 atomicity Note: coldvox-audio compiles and tests pass. coldvox-app has pre-existing API signature mismatches (AudioCaptureThread::spawn) that need separate fix. Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: ColdVox Dev <[email protected]> Co-authored-by: Claude <[email protected]> * [03/09] vad: windowing/debounce consistency (#125) * [01/09] config: centralize Settings + path-aware load * Add config dependency and lib section to Cargo.toml * Update Cargo.lock for config dependency * [02/09] audio: capture lifecycle fix + ALSA stderr suppression * [03/09] vad: windowing/debounce consistency --------- Co-authored-by: ColdVox Dev <[email protected]> * [04/09] stt: finalize handling + helpers (#126) * [01/09] config: centralize Settings + path-aware load * Add config dependency and lib section to Cargo.toml * Update Cargo.lock for config dependency * [02/09] audio: capture lifecycle fix + ALSA stderr suppression * [03/09] vad: windowing/debounce consistency * [04/09] stt: finalize handling + helpers * fix: add constants module declaration to coldvox-stt - Declare pub mod constants in lib.rs - Note: helpers.rs not declared due to circular dependency with coldvox-telemetry - helpers.rs is currently unused and can be integrated when telemetry refactor resolves cycle 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * fix(stt): add module decls, clean imports, constants (#126) - Add constants module declaration to lib.rs - Move SttMetrics from processor.rs to types.rs (breaks circular dependency) - Clean imports in helpers.rs (remove circular import, alphabetize) - Replace magic numbers in processor.rs with named constants: - 16000 -> SAMPLE_RATE_HZ - 10 -> DEFAULT_BUFFER_DURATION_SECONDS - 100 -> LOGGING_INTERVAL_FRAMES - 5 -> SEND_TIMEOUT_SECONDS - Comment out helpers module (requires coldvox_telemetry, should move to app crate) Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: ColdVox Dev <[email protected]> Co-authored-by: Claude <[email protected]> --------- Co-authored-by: ColdVox Dev <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: Coldaine <[email protected]> --------- Co-authored-by: ColdVox Dev <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: Coldaine <[email protected]>
Coldaine
added a commit
that referenced
this pull request
Oct 8, 2025
* [08/09] logs: prune noisy hot paths; telemetry tweaks * fix: replace hardcoded device with env var and fallback chain - Use COLDVOX_TEST_DEVICE env var if set - Fall back to ctx.device from test context - Fall back to default device detection if neither specified - Improves portability across different hardware setups 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * fix(logging): remove hardcoded device; add env/ctx fallback (#130) - Replace hardcoded "HyperX QuadCast" device in vad_mic.rs with flexible fallback: 1. Check COLDVOX_TEST_DEVICE env var first 2. Fall back to TestContext.device 3. Use None for default enumeration if neither specified - Add warning log when falling back to default enumeration - Add TODO(#130) comment for misnamed counter `requests_per_second` → `total_requests` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * [01/09] config: centralize Settings + path-aware load (#123) * [01/09] config: centralize Settings + path-aware load * Add config dependency and lib section to Cargo.toml * Update Cargo.lock for config dependency * fix(ci): resolve Vosk setup issues for self-hosted runner - Fix cache path mismatch: script now checks alternate cache locations (/vosk-models vs /vosk) with fallback logic - Switch to large production model: vosk-model-en-us-0.22 (1.8GB) - Update model checksum to match current alphacephei.com version - Add libvosk fallback: checks cache, alternate cache, and system paths - Make GITHUB_OUTPUT optional for local testing - Add comprehensive test suite: test_vosk_setup.sh mimics CI workflow - Add detailed verification report: VOSK_SETUP_VERIFICATION.md Resolves model download and linking failures in CI workflows. All verification tests pass locally on self-hosted runner. Tested: - Setup script execution (symlinks created correctly) - Build: cargo build -p coldvox-stt-vosk --features vosk ✅ - Unit tests: 3/3 passed ✅ - Model structure validation ✅ * debugging * Add build.rs to link vendored libvosk at compile time Fixes linker error 'unable to find library -lvosk' by: - Adding vendor/vosk/lib to rustc link search path - Setting rpath for runtime library discovery - Falling back to system paths (/usr/local/lib, /usr/lib64, /usr/lib) - Using cargo:rerun-if-changed for efficient rebuilds Addresses issue documented in docs/dev/THE_MISSING_LINK.md. Follows Rust best practices per Cargo book build script guidelines. Tested with: cargo check -p coldvox-stt-vosk --features vosk * fix: Update main.rs to match runtime struct definitions - Remove non-existent 'enable_device_monitor' field from AppRuntimeOptions - Update InjectionOptions initialization to match actual struct fields - Add missing 'allow_ydotool' and 'restore_clipboard' fields This fixes compilation errors when building coldvox-app with vosk features. * chore: retrigger CI after runner restart * test: trigger CI after fixing Rust version * docs: Add comprehensive self-hosted runner management architecture Create complete runnerAgent documentation system for managing and optimizing the self-hosted GitHub Actions runner (laptop-extra). Structure: - README.md: Quick start guide with daily workflows and debugging commands - RunnerAgent.md: Complete architecture document with system design - IMPLEMENTATION.md: Usage patterns, integration guide, and next steps - prompts/: LLM assistant configurations for specialized tasks - debug_agent_prompt.md: CI failure diagnosis workflows - system_update_prompt.md: Dependency and toolchain maintenance - performance_monitor_prompt.md: Build/test optimization strategies Key features: - Executable commands for common operations (health checks, log analysis) - LLM-ready prompts for AI-assisted debugging with tools like gemini CLI - Local-first approach leveraging direct hardware access - Performance monitoring and optimization guidelines - Integration with existing CI workflows and scripts Benefits: - Self-service debugging without admin access - Faster iteration (test locally before pushing) - Performance visibility and tracking - Reproducible maintenance workflows Related: PR #123 (requires runner toolchain update to pass CI) * docs(runnerAgent): include absolute runner workspace path /home/coldaine/actions-runner/_work/ColdVox/ColdVox in key docs * docs(runnerAgent): add gemini-based runner debugger script and README note --------- Co-authored-by: ColdVox Dev <[email protected]> Co-authored-by: Coldaine <[email protected]> * [02/09] audio: capture lifecycle fix + ALSA stderr suppression (#124) * [01/09] config: centralize Settings + path-aware load * Add config dependency and lib section to Cargo.toml * Update Cargo.lock for config dependency * [02/09] audio: capture lifecycle fix + ALSA stderr suppression * fix(audio): decouple wav_file_loader decl, cfg(unix) + safety notes (#124) - Remove wav_file_loader module declaration from app/audio/mod.rs (decouples #124 from #127 dependency) - Remove misplaced STT plugins.json from crates/coldvox-audio/ (STT config belongs in app-level or config/ directory, not audio crate) - Add #[cfg(unix)] guards to stderr_suppressor module and usage (Unix-specific file descriptor operations) - Add comprehensive SAFETY documentation to all unsafe blocks in stderr_suppressor.rs explaining FD ownership and dup2 atomicity Note: coldvox-audio compiles and tests pass. coldvox-app has pre-existing API signature mismatches (AudioCaptureThread::spawn) that need separate fix. Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: ColdVox Dev <[email protected]> Co-authored-by: Claude <[email protected]> * [03/09] vad: windowing/debounce consistency (#125) * [01/09] config: centralize Settings + path-aware load * Add config dependency and lib section to Cargo.toml * Update Cargo.lock for config dependency * [02/09] audio: capture lifecycle fix + ALSA stderr suppression * [03/09] vad: windowing/debounce consistency --------- Co-authored-by: ColdVox Dev <[email protected]> * [04/09] stt: finalize handling + helpers (#126) * [01/09] config: centralize Settings + path-aware load * Add config dependency and lib section to Cargo.toml * Update Cargo.lock for config dependency * [02/09] audio: capture lifecycle fix + ALSA stderr suppression * [03/09] vad: windowing/debounce consistency * [04/09] stt: finalize handling + helpers * fix: add constants module declaration to coldvox-stt - Declare pub mod constants in lib.rs - Note: helpers.rs not declared due to circular dependency with coldvox-telemetry - helpers.rs is currently unused and can be integrated when telemetry refactor resolves cycle 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * fix(stt): add module decls, clean imports, constants (#126) - Add constants module declaration to lib.rs - Move SttMetrics from processor.rs to types.rs (breaks circular dependency) - Clean imports in helpers.rs (remove circular import, alphabetize) - Replace magic numbers in processor.rs with named constants: - 16000 -> SAMPLE_RATE_HZ - 10 -> DEFAULT_BUFFER_DURATION_SECONDS - 100 -> LOGGING_INTERVAL_FRAMES - 5 -> SEND_TIMEOUT_SECONDS - Comment out helpers module (requires coldvox_telemetry, should move to app crate) Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: ColdVox Dev <[email protected]> Co-authored-by: Claude <[email protected]> --------- Co-authored-by: ColdVox Dev <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: Coldaine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part 2 of 9 in the domain-based refactor split.
Fixes audio capture lifecycle management and suppresses ALSA stderr noise for cleaner logging.
Changes
Audio Crate (
crates/coldvox-audio/**)App Integration
crates/app/src/audio/mod.rs: Audio module organizationcrates/app/src/audio/vad_processor.rs: VAD processor integration with audio pipelineDependencies
Validation
cargo check --workspace cargo test -p coldvox-audio cargo run --bin mic_probe -- --duration 10Metrics
Review Notes
Stack position: 2/9
Previous PR: #1 (config-settings)
Next PR: #3 (vad)