-
Notifications
You must be signed in to change notification settings - Fork 0
chore(stt): remove stub STT plugin files #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||||||||
qodo-free-for-open-source-projects
bot
commented
Dec 11, 2025
•
edited by qodo-code-review
bot
Loading
edited by qodo-code-review
bot
PR Code Suggestions ✨No code suggestions found for the PR. |
1 similar comment
PR Code Suggestions ✨No code suggestions found for the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes unimplemented stub STT plugin files to clean up the codebase. The deleted plugins (coqui, leopard, silero_stt, whisper_cpp, and whisper_plugin) were all placeholder implementations that returned "not yet implemented" errors. This consolidates the codebase to only include production-ready plugins (parakeet, moonshine) and utility plugins (mock, noop).
Key changes:
- Removed 5 stub plugin files totaling ~2,100 lines of placeholder code
- Updated mod.rs to remove conditional compilation directives for deleted plugins
- Preserved production plugins: parakeet (NVIDIA GPU), moonshine (CPU), mock (test), and noop (null)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/coldvox-stt/src/plugins/whisper_plugin.rs | Removed 943-line stub implementation of Faster-Whisper STT with GPU detection caching and model size selection |
| crates/coldvox-stt/src/plugins/whisper_cpp.rs | Removed 374-line stub for whisper.cpp C++ implementation with GGML quantization support |
| crates/coldvox-stt/src/plugins/silero_stt.rs | Removed 303-line stub for ONNX-based Silero STT with multiple language support |
| crates/coldvox-stt/src/plugins/leopard.rs | Removed 233-line stub for commercial Picovoice Leopard STT engine |
| crates/coldvox-stt/src/plugins/coqui.rs | Removed 223-line stub for Coqui STT (Mozilla DeepSpeech fork) |
| crates/coldvox-stt/src/plugins/mod.rs | Cleaned up module declarations by removing feature-gated imports for deleted plugins |
| // Re-export commonly used plugins | ||
| pub use mock::MockPlugin; | ||
| pub use noop::NoOpPlugin; |
Copilot
AI
Dec 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of whisper_plugin.rs creates broken references in crates/app/src/stt/plugin_manager.rs. Lines 572-573 and 1522 still reference coldvox_stt::plugins::whisper_plugin::WhisperPluginFactory, which will cause compilation failures when the whisper feature is enabled. These references need to be removed or updated to match the new whisper implementation when it's available.
| // Re-export commonly used plugins | ||
| pub use mock::MockPlugin; | ||
| pub use noop::NoOpPlugin; |
Copilot
AI
Dec 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature flags coqui, leopard, and silero-stt should be removed from crates/coldvox-stt/Cargo.toml (lines 33-35) since the corresponding plugin implementations have been deleted. Leaving empty feature flags can be confusing and suggests functionality that doesn't exist. The whisper feature flag may be intentionally kept as a placeholder for future implementation based on the comment on line 31 of Cargo.toml.
Remove unimplemented stub plugins that were placeholders: - coqui.rs - leopard.rs - silero_stt.rs - whisper_cpp.rs - whisper_plugin.rs These files contained skeleton code that was never implemented. Keeping production plugins: parakeet (GPU), moonshine (CPU), mock, noop. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Vosk was removed in commit 6dffdb5 but references remained in: - GitHub workflows and actions (.github/workflows/vosk-integration.yml) - GitHub action setup description - Job classifier configuration - Documentation (ADRs, guides, design docs, planning docs) Replace STT references with Parakeet (GPU) and Moonshine (CPU) where appropriate. Updated configuration examples and documentation to reference current STT plugins. Files deleted: - .github/workflows/vosk-integration.yml - docs/adr/0001-vosk-model-distribution.md - docs/domains/stt/troubleshooting/vosk-model-discovery.md - docs/reference/crates/coldvox-stt-vosk.md Files updated: - .github/actions/setup-coldvox/action.yml - .github/workflow-job-classifier.yml - CHANGELOG.md - docs/domains/audio/aud-user-config-design.md - docs/domains/foundation/fdn-voice-pipeline-core-design.md - docs/domains/foundation/fdn-testing-guide.md - All planning and research documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
914fc2d to
610ce95
Compare
User description
Summary
coqui.rsleopard.rssilero_stt.rswhisper_cpp.rswhisper_plugin.rsmod.rsto remove references to deleted pluginsWhat remains (production plugins)
parakeet.rs- NVIDIA GPU pluginmoonshine.rs- CPU plugin (PR feat(stt): add Moonshine CPU STT plugin via PyO3/HuggingFace #259)mock.rs- Test pluginnoop.rs- Null pluginNotes
This replaces the broken
chore/cleanup-deprecated-codebranch which incorrectly deletedmoonshine.rs.Test plan
cargo check -p coldvox-sttpassescargo build --features parakeetworkscargo build --features moonshineworks🤖 Generated with Claude Code
PR Type
Enhancement
Description
Remove 5 unimplemented stub STT plugin files
Update mod.rs to remove feature flags and module declarations
Retain production plugins: parakeet, moonshine, mock, noop
Diagram Walkthrough
File Walkthrough
coqui.rs
Remove Coqui STT stub plugincrates/coldvox-stt/src/plugins/coqui.rs
leopard.rs
Remove Leopard STT stub plugincrates/coldvox-stt/src/plugins/leopard.rs
silero_stt.rs
Remove Silero STT stub plugincrates/coldvox-stt/src/plugins/silero_stt.rs
whisper_cpp.rs
Remove whisper.cpp stub plugincrates/coldvox-stt/src/plugins/whisper_cpp.rs
whisper_plugin.rs
Remove faster-whisper stub plugincrates/coldvox-stt/src/plugins/whisper_plugin.rs
transcription
production-ready
mod.rs
Update module declarations for active pluginscrates/coldvox-stt/src/plugins/mod.rs
silero-stt
(feature-gated)