Skip to content

Conversation

@Coldaine
Copy link
Owner

@Coldaine Coldaine commented Dec 11, 2025

User description

Summary

  • Remove unimplemented stub STT plugins that were placeholders:
    • coqui.rs
    • leopard.rs
    • silero_stt.rs
    • whisper_cpp.rs
    • whisper_plugin.rs
  • Update mod.rs to remove references to deleted plugins

What remains (production plugins)

Notes

This replaces the broken chore/cleanup-deprecated-code branch which incorrectly deleted moonshine.rs.

Test plan

  • cargo check -p coldvox-stt passes
  • cargo build --features parakeet works
  • cargo build --features moonshine works

🤖 Generated with Claude Code


PR Type

Enhancement


Description

  • Remove 5 unimplemented stub STT plugin files

    • coqui.rs, leopard.rs, silero_stt.rs, whisper_cpp.rs, whisper_plugin.rs
  • Update mod.rs to remove feature flags and module declarations

  • Retain production plugins: parakeet, moonshine, mock, noop


Diagram Walkthrough

flowchart LR
  A["STT Plugins"] -->|Remove stubs| B["Production Only"]
  C["coqui.rs"] -.->|deleted| B
  D["leopard.rs"] -.->|deleted| B
  E["silero_stt.rs"] -.->|deleted| B
  F["whisper_cpp.rs"] -.->|deleted| B
  G["whisper_plugin.rs"] -.->|deleted| B
  H["parakeet.rs"] -->|kept| B
  I["moonshine.rs"] -->|kept| B
  J["mock.rs"] -->|kept| B
  K["noop.rs"] -->|kept| B
Loading

File Walkthrough

Relevant files
Miscellaneous
coqui.rs
Remove Coqui STT stub plugin                                                         

crates/coldvox-stt/src/plugins/coqui.rs

  • Deleted entire file containing unimplemented Coqui STT plugin
  • Removed 223 lines of stub code with config, plugin struct, and factory
  • Plugin returned NotAvailable errors for all operations
+0/-223 
leopard.rs
Remove Leopard STT stub plugin                                                     

crates/coldvox-stt/src/plugins/leopard.rs

  • Deleted entire file containing unimplemented Leopard plugin
  • Removed 233 lines of stub code for Picovoice's commercial STT
  • Plugin required license key but was not functional
+0/-233 
silero_stt.rs
Remove Silero STT stub plugin                                                       

crates/coldvox-stt/src/plugins/silero_stt.rs

  • Deleted entire file containing unimplemented Silero STT plugin
  • Removed 303 lines of stub code with ONNX model support
  • Included model variants and configuration but no actual implementation
+0/-303 
whisper_cpp.rs
Remove whisper.cpp stub plugin                                                     

crates/coldvox-stt/src/plugins/whisper_cpp.rs

  • Deleted entire file containing unimplemented whisper.cpp plugin
  • Removed 374 lines of stub code with model types and configuration
  • Plugin supported multiple model sizes but was not functional
+0/-374 
whisper_plugin.rs
Remove faster-whisper stub plugin                                               

crates/coldvox-stt/src/plugins/whisper_plugin.rs

  • Deleted entire file containing unimplemented faster-whisper plugin
  • Removed 943 lines of code including GPU detection, model loading, and
    transcription
  • Contained comprehensive implementation with tests but was not
    production-ready
+0/-943 
Configuration changes
mod.rs
Update module declarations for active plugins                       

crates/coldvox-stt/src/plugins/mod.rs

  • Removed feature-gated module declarations for whisper, coqui, leopard,
    silero-stt
  • Removed commented-out whisper_plugin module reference
  • Kept only mock, noop, parakeet (feature-gated), and moonshine
    (feature-gated)
  • Removed re-exports for deleted plugins
+0/-15   

@qodo-free-for-open-source-projects
Copy link

qodo-free-for-open-source-projects bot commented Dec 11, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
No audit logs: The new changes only adjust module declarations and re-exports without adding or affecting
any critical action logic or logging, so audit trail compliance cannot be assessed from
this diff alone.

Referred Code
//! Built-in STT plugin implementations

pub mod mock;
pub mod noop;

#[cfg(feature = "parakeet")]
pub mod parakeet;

#[cfg(feature = "moonshine")]
pub mod moonshine;

// Re-export commonly used plugins
pub use mock::MockPlugin;
pub use noop::NoOpPlugin;

#[cfg(feature = "parakeet")]
pub use parakeet::ParakeetPluginFactory;

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
No error paths: The diff only modifies module gating and re-exports and introduces no error-producing
code, so robustness of error handling cannot be evaluated from these additions.

Referred Code
//! Built-in STT plugin implementations

pub mod mock;
pub mod noop;

#[cfg(feature = "parakeet")]
pub mod parakeet;

#[cfg(feature = "moonshine")]
pub mod moonshine;

// Re-export commonly used plugins
pub use mock::MockPlugin;
pub use noop::NoOpPlugin;

#[cfg(feature = "parakeet")]
pub use parakeet::ParakeetPluginFactory;

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status:
No input handling: The added lines only manage module exposure and do not process external inputs, so input
validation and data handling security cannot be determined from this diff.

Referred Code
//! Built-in STT plugin implementations

pub mod mock;
pub mod noop;

#[cfg(feature = "parakeet")]
pub mod parakeet;

#[cfg(feature = "moonshine")]
pub mod moonshine;

// Re-export commonly used plugins
pub use mock::MockPlugin;
pub use noop::NoOpPlugin;

#[cfg(feature = "parakeet")]
pub use parakeet::ParakeetPluginFactory;

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-free-for-open-source-projects
Copy link

qodo-free-for-open-source-projects bot commented Dec 11, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

1 similar comment
@qodo-code-review
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unimplemented stub STT plugin files to clean up the codebase. The deleted plugins (coqui, leopard, silero_stt, whisper_cpp, and whisper_plugin) were all placeholder implementations that returned "not yet implemented" errors. This consolidates the codebase to only include production-ready plugins (parakeet, moonshine) and utility plugins (mock, noop).

Key changes:

  • Removed 5 stub plugin files totaling ~2,100 lines of placeholder code
  • Updated mod.rs to remove conditional compilation directives for deleted plugins
  • Preserved production plugins: parakeet (NVIDIA GPU), moonshine (CPU), mock (test), and noop (null)

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
crates/coldvox-stt/src/plugins/whisper_plugin.rs Removed 943-line stub implementation of Faster-Whisper STT with GPU detection caching and model size selection
crates/coldvox-stt/src/plugins/whisper_cpp.rs Removed 374-line stub for whisper.cpp C++ implementation with GGML quantization support
crates/coldvox-stt/src/plugins/silero_stt.rs Removed 303-line stub for ONNX-based Silero STT with multiple language support
crates/coldvox-stt/src/plugins/leopard.rs Removed 233-line stub for commercial Picovoice Leopard STT engine
crates/coldvox-stt/src/plugins/coqui.rs Removed 223-line stub for Coqui STT (Mozilla DeepSpeech fork)
crates/coldvox-stt/src/plugins/mod.rs Cleaned up module declarations by removing feature-gated imports for deleted plugins

Comment on lines 12 to 14
// Re-export commonly used plugins
pub use mock::MockPlugin;
pub use noop::NoOpPlugin;
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of whisper_plugin.rs creates broken references in crates/app/src/stt/plugin_manager.rs. Lines 572-573 and 1522 still reference coldvox_stt::plugins::whisper_plugin::WhisperPluginFactory, which will cause compilation failures when the whisper feature is enabled. These references need to be removed or updated to match the new whisper implementation when it's available.

Copilot uses AI. Check for mistakes.
Comment on lines 12 to 14
// Re-export commonly used plugins
pub use mock::MockPlugin;
pub use noop::NoOpPlugin;
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature flags coqui, leopard, and silero-stt should be removed from crates/coldvox-stt/Cargo.toml (lines 33-35) since the corresponding plugin implementations have been deleted. Leaving empty feature flags can be confusing and suggests functionality that doesn't exist. The whisper feature flag may be intentionally kept as a placeholder for future implementation based on the comment on line 31 of Cargo.toml.

Copilot uses AI. Check for mistakes.
substrate-bot and others added 2 commits December 23, 2025 15:50
Remove unimplemented stub plugins that were placeholders:
- coqui.rs
- leopard.rs
- silero_stt.rs
- whisper_cpp.rs
- whisper_plugin.rs

These files contained skeleton code that was never implemented.
Keeping production plugins: parakeet (GPU), moonshine (CPU), mock, noop.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Vosk was removed in commit 6dffdb5 but references remained in:
- GitHub workflows and actions (.github/workflows/vosk-integration.yml)
- GitHub action setup description
- Job classifier configuration
- Documentation (ADRs, guides, design docs, planning docs)

Replace STT references with Parakeet (GPU) and Moonshine (CPU) where appropriate.
Updated configuration examples and documentation to reference current STT plugins.

Files deleted:
- .github/workflows/vosk-integration.yml
- docs/adr/0001-vosk-model-distribution.md
- docs/domains/stt/troubleshooting/vosk-model-discovery.md
- docs/reference/crates/coldvox-stt-vosk.md

Files updated:
- .github/actions/setup-coldvox/action.yml
- .github/workflow-job-classifier.yml
- CHANGELOG.md
- docs/domains/audio/aud-user-config-design.md
- docs/domains/foundation/fdn-voice-pipeline-core-design.md
- docs/domains/foundation/fdn-testing-guide.md
- All planning and research documentation

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@Coldaine Coldaine force-pushed the cleanup/remove-stub-plugins-v2 branch from 914fc2d to 610ce95 Compare December 23, 2025 21:53
@Coldaine Coldaine merged commit b2e89c8 into main Dec 23, 2025
6 checks passed
@Coldaine Coldaine deleted the cleanup/remove-stub-plugins-v2 branch December 23, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants