site footer template situation #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o match what we have in cwd_base (markup/layout changes can be done separately) Issue #22
|
@ama39 I guess the styling match-up didn't QUITE work out as I'd hoped. I used markup from LASSP, but I guess there must be some styles that go with LASSP that we don't have in cwd_base/cwd_project. Could you please take a look and lmk if a markup change would do the trick, or if style changes are needed?
(The markup is not the same, because I switched the block order so things are in the correct places, I just thought, maybe it would work out anyway -- I was wrong 🙃) |
…template code from LASSP) Issue #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review on "alison" multidev on CD Demo:
https://alison-cddemo.pantheonsite.io/
Closes #22
Goes with PRs on cwd_base and cd_drupal_upstream.