Skip to content

site footer template situation #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

site footer template situation #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1df75a
use site-footer partial template for realzies; update footer markup t…
alisonjo315 Oct 7, 2022
c212250
oops, there are only two footer regions (mistake from reusing footer …
alisonjo315 Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions templates/html.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@
{{ page }}
{{ page_bottom }}

{# Not ready to use yet b/c footer stuff is included in cwd_base/page.html.twig.
Placeholder footer template is in @cwd_project/partials, ready to use down the road -- or for use by new child themes.
{% include "@cwd_project/partials/site-footer.html.twig" %} #}
{% include "@cwd_project/partials/site-footer.html.twig" %}

<js-bottom-placeholder token="{{ placeholder_token|raw }}">
<!-- Emergency banner removed March 2021 -->
Expand Down
32 changes: 19 additions & 13 deletions templates/partials/site-footer.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
{# PLACEHOLDER until if/when footer stuff is removed from cwd_base/page.html.twig, or we add a page.html.twig template override to cwd_project. #}
<footer aria-label="Site footer">
<footer id="body-footer" aria-label="Site footer">
<div class="main-footer">
<div class="container-fluid sidebar-left">
<div class="row">
<div class="primary">
{{ page.footer_primary }}
</div>
<div class="secondary">
{{ page.footer_secondary }}
<div class="flex-grid">
<div class="flex-6">
{{ page.footer_primary }}
</div>
<div class="flex-6">
{{ page.footer_secondary }}
</div>
</div>
</div>
</div>
Expand All @@ -16,12 +17,17 @@
<div class="container-fluid sidebar-left">
<div class="row">
<div class="content">
<div class="privacy">
<a href="#">University Privacy</a>
</div>

<div class="footer-accessibility">
<a href="https://www.cornell.edu/accessibility-assistance.cfm">Web Accessibility Assistance</a>
<div class="two-col">
<div>
<ul class="custom inline no-bullet">
<li><a href="https://privacy.cornell.edu/">University Privacy</a></li>
</ul>
</div>
<div>
<ul class="custom inline no-bullet">
<li><a href="mailto:[email protected]">Web Accessibility Assistance</a></li>
</ul>
</div>
</div>
</div>
</div>
Expand Down