Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/util/crio] Add missing go build tag #33590

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

davidor
Copy link
Member

@davidor davidor commented Jan 30, 2025

What does this PR do?

Adds a missing go build tag.
The code in pkg/util/crio/crio_util.go is specific for crio, and we have a crio build tag, so we should use it here.

Describe how you validated your changes

Automated tests should be enough.

@davidor davidor added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Jan 30, 2025
@davidor davidor added this to the 7.64.0 milestone Jan 30, 2025
@davidor davidor requested a review from a team as a code owner January 30, 2025 16:24
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jan 30, 2025
@davidor
Copy link
Member Author

davidor commented Feb 3, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 3, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-03 07:30:59 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 27m.


2025-02-03 07:57:13 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 544e705 into main Feb 3, 2025
248 checks passed
@dd-mergequeue dd-mergequeue bot deleted the davidor/missing-build-tag-crio branch February 3, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants