-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Bump minimum supported macOS ABI as advertised (ABLD-28 follow-up) #41945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum supported macOS ABI as advertised (ABLD-28 follow-up) #41945
Conversation
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 1f16039 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +0.38 | [-1.08, +1.84] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_metrics_logs | memory utilization | +1.41 | [+1.19, +1.62] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | +0.55 | [+0.42, +0.69] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.41 | [+0.35, +0.47] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | +0.38 | [-1.08, +1.84] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.24 | [+0.08, +0.40] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.17 | [-0.01, +0.35] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.15 | [+0.02, +0.27] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +0.10 | [-2.71, +2.91] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.08 | [-0.11, +0.27] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.07 | [+0.03, +0.12] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.04 | [-0.56, +0.64] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.02 | [-0.60, +0.64] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.24, +0.26] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.01 | [-0.14, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.03 | [-0.62, +0.57] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.03 | [-0.62, +0.57] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.10 | [-0.55, +0.36] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.18 | [-0.22, -0.15] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | -0.23 | [-0.27, -0.19] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.24 | [-0.28, -0.20] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.31 | [-0.43, -0.19] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
### What does this PR do? This aligns (up) the minimum supported macOS ABI to 11.0, as otherwise [documented](https://docs.datadoghq.com/agent/supported_platforms/?tab=macos). ### Motivation 1. establish a baseline for binary sizes (static quality gates) with a single ABI version so that we'd get the same with Bazel builds, 2. macOS ABI 10.x is no longer officially supported since Agent [7.62.0](https://github.com/DataDog/datadog-agent/releases/tag/7.62.0) (Jan 29, 2025) according to: <img width="621" height="471" alt="image" src="https://github.com/user-attachments/assets/1affd02f-bdf0-478d-8a1b-0e66d7ddbd57" /> Some bundled dependencies are anyway already depending on a greater ABI, for instance: - [snowflake_connector_python-3.17.2-cp312-cp312-macosx_11_0_x86_64.whl](https://github.com/DataDog/integrations-core/blob/d3f7387a09725bd2e30b7466c0edfc34b2fb6f45/.deps/resolved/macos-x86_64_3.12.txt#L111) (11.0) - [ddtrace-3.12.5-cp312-cp312-macosx_12_0_x86_64.whl](https://github.com/DataDog/integrations-core/blob/d3f7387a09725bd2e30b7466c0edfc34b2fb6f45/.deps/resolved/macos-x86_64_3.12.txt#L21) (**12.0**) ### Additional Notes There are multiple points of maintenance we'll centralize in the frame of the ongoing migration to Bazel. See also: - DataDog/integrations-core#21652 2a47829
What does this PR do?
This aligns (up) the minimum supported macOS ABI to 11.0, as otherwise documented.
Motivation
Some bundled dependencies are anyway already depending on a greater ABI, for instance:
Additional Notes
There are multiple points of maintenance we'll centralize in the frame of the ongoing migration to Bazel.
See also: