-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Bump minimum supported macOS ABI as advertised (ABLD-28 follow-up) #21652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum supported macOS ABI as advertised (ABLD-28 follow-up) #21652
Conversation
3a02e50
to
4c38435
Compare
### What does this PR do? This aligns (up) the minimum supported macOS ABI to 11.0, as otherwise [documented](https://docs.datadoghq.com/agent/supported_platforms/?tab=macos). ### Motivation 1. establish a baseline for binary sizes (static quality gates) with a single ABI version so that we'd get the same with Bazel builds, 2. macOS ABI 10.x is no longer officially supported since Agent [7.62.0](https://github.com/DataDog/datadog-agent/releases/tag/7.62.0) (Jan 29, 2025) according to: <img width="621" height="471" alt="image" src="https://github.com/user-attachments/assets/1affd02f-bdf0-478d-8a1b-0e66d7ddbd57" /> Some bundled dependencies are anyway already depending on a greater ABI, for instance: - [snowflake_connector_python-3.17.2-cp312-cp312-macosx_11_0_x86_64.whl](https://github.com/DataDog/integrations-core/blob/d3f7387a09725bd2e30b7466c0edfc34b2fb6f45/.deps/resolved/macos-x86_64_3.12.txt#L111) (11.0) - [ddtrace-3.12.5-cp312-cp312-macosx_12_0_x86_64.whl](https://github.com/DataDog/integrations-core/blob/d3f7387a09725bd2e30b7466c0edfc34b2fb6f45/.deps/resolved/macos-x86_64_3.12.txt#L21) (**12.0**) ### Additional Notes There are multiple points of maintenance we'll centralize in the frame of the ongoing migration to Bazel. See also: - DataDog/integrations-core#21652
### What does this PR do? This aligns (up) the minimum supported macOS ABI to 11.0, as otherwise [documented](https://docs.datadoghq.com/agent/supported_platforms/?tab=macos). ### Motivation 1. establish a baseline for binary sizes (static quality gates) with a single ABI version so that we'd get the same with Bazel builds, 2. macOS ABI 10.x is no longer officially supported since Agent [7.62.0](https://github.com/DataDog/datadog-agent/releases/tag/7.62.0) (Jan 29, 2025) according to: <img width="621" height="471" alt="image" src="https://github.com/user-attachments/assets/1affd02f-bdf0-478d-8a1b-0e66d7ddbd57" /> Some bundled dependencies are anyway already depending on a greater ABI, for instance: - [snowflake_connector_python-3.17.2-cp312-cp312-macosx_11_0_x86_64.whl](https://github.com/DataDog/integrations-core/blob/d3f7387a09725bd2e30b7466c0edfc34b2fb6f45/.deps/resolved/macos-x86_64_3.12.txt#L111) (11.0) - [ddtrace-3.12.5-cp312-cp312-macosx_12_0_x86_64.whl](https://github.com/DataDog/integrations-core/blob/d3f7387a09725bd2e30b7466c0edfc34b2fb6f45/.deps/resolved/macos-x86_64_3.12.txt#L21) (**12.0**) ### Additional Notes There are multiple points of maintenance we'll centralize in the frame of the ongoing migration to Bazel. See also: - DataDog/integrations-core#21652 2a47829
This aligns (up) the minimum supported macOS ABI to 11.0, as otherwise [documented](https://docs.datadoghq.com/agent/supported_platforms/?tab=macos). macOS ABI 10.x is no longer officially supported since Agent [7.62.0](https://github.com/DataDog/datadog-agent/releases/tag/7.62.0) (Jan 29, 2025). There are multiple points of maintenance we'll centralize in the frame of the ongoing migration to Bazel.
4c38435
to
0f5f3ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though this makes the behavior conform to the docs, we should consider mentioning that in the releasee notes as it changes undocumented behavior.
|
….0 ABI (#42155) ### What does this PR do? Clarify the advertised mininum ABI version is now observed by the `x86_64` build of the Agent for macOS. ### Motivation > Even though this makes the behavior conform to the docs, we should consider mentioning that in the release notes as it changes undocumented behavior. (DataDog/integrations-core#21652 (review))
What does this PR do?
This aligns (up) the minimum supported macOS ABI to 11.0, as otherwise documented.
Motivation
Some bundled dependencies are anyway already depending on a greater ABI, for instance:
integrations-core/.deps/resolved/macos-x86_64_3.12.txt
Line 111 in d3f7387
integrations-core/.deps/resolved/macos-x86_64_3.12.txt
Line 21 in d3f7387
Additional Notes
There are multiple points of maintenance we'll centralize in the frame of the ongoing migration to Bazel.
See also: