Skip to content

Conversation

rdesgroppes
Copy link
Contributor

@rdesgroppes rdesgroppes commented Oct 14, 2025

What does this PR do?

This aligns (up) the minimum supported macOS ABI to 11.0, as otherwise documented.

Motivation

  1. establish a baseline for binary sizes (static quality gates) with a single ABI version so that we'd get the same with Bazel builds,
  2. macOS ABI 10.x is no longer officially supported since Agent 7.62.0 (Jan 29, 2025) according to:
image

Some bundled dependencies are anyway already depending on a greater ABI, for instance:

Additional Notes

There are multiple points of maintenance we'll centralize in the frame of the ongoing migration to Bazel.
See also:

@rdesgroppes rdesgroppes requested review from a team as code owners October 14, 2025 15:41
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/bump-minimum-supported-macos-abi-as-advertised branch from 3a02e50 to 4c38435 Compare October 14, 2025 15:43
rdesgroppes added a commit to DataDog/datadog-agent that referenced this pull request Oct 15, 2025
### What does this PR do?
This aligns (up) the minimum supported macOS ABI to 11.0, as otherwise
[documented](https://docs.datadoghq.com/agent/supported_platforms/?tab=macos).

### Motivation
1. establish a baseline for binary sizes (static quality gates) with a
single ABI version so that we'd get the same with Bazel builds,
2. macOS ABI 10.x is no longer officially supported since Agent
[7.62.0](https://github.com/DataDog/datadog-agent/releases/tag/7.62.0)
(Jan 29, 2025) according to:
<img width="621" height="471" alt="image"
src="https://github.com/user-attachments/assets/1affd02f-bdf0-478d-8a1b-0e66d7ddbd57"
/>

Some bundled dependencies are anyway already depending on a greater ABI,
for instance:
-
[snowflake_connector_python-3.17.2-cp312-cp312-macosx_11_0_x86_64.whl](https://github.com/DataDog/integrations-core/blob/d3f7387a09725bd2e30b7466c0edfc34b2fb6f45/.deps/resolved/macos-x86_64_3.12.txt#L111)
(11.0)
-
[ddtrace-3.12.5-cp312-cp312-macosx_12_0_x86_64.whl](https://github.com/DataDog/integrations-core/blob/d3f7387a09725bd2e30b7466c0edfc34b2fb6f45/.deps/resolved/macos-x86_64_3.12.txt#L21)
(**12.0**)

### Additional Notes
There are multiple points of maintenance we'll centralize in the frame
of the ongoing migration to Bazel.
See also:
- DataDog/integrations-core#21652
github-actions bot pushed a commit to Bettdatt/datadog-agent that referenced this pull request Oct 15, 2025
### What does this PR do?
This aligns (up) the minimum supported macOS ABI to 11.0, as otherwise
[documented](https://docs.datadoghq.com/agent/supported_platforms/?tab=macos).

### Motivation
1. establish a baseline for binary sizes (static quality gates) with a
single ABI version so that we'd get the same with Bazel builds,
2. macOS ABI 10.x is no longer officially supported since Agent
[7.62.0](https://github.com/DataDog/datadog-agent/releases/tag/7.62.0)
(Jan 29, 2025) according to:
<img width="621" height="471" alt="image"
src="https://github.com/user-attachments/assets/1affd02f-bdf0-478d-8a1b-0e66d7ddbd57"
/>

Some bundled dependencies are anyway already depending on a greater ABI,
for instance:
-
[snowflake_connector_python-3.17.2-cp312-cp312-macosx_11_0_x86_64.whl](https://github.com/DataDog/integrations-core/blob/d3f7387a09725bd2e30b7466c0edfc34b2fb6f45/.deps/resolved/macos-x86_64_3.12.txt#L111)
(11.0)
-
[ddtrace-3.12.5-cp312-cp312-macosx_12_0_x86_64.whl](https://github.com/DataDog/integrations-core/blob/d3f7387a09725bd2e30b7466c0edfc34b2fb6f45/.deps/resolved/macos-x86_64_3.12.txt#L21)
(**12.0**)

### Additional Notes
There are multiple points of maintenance we'll centralize in the frame
of the ongoing migration to Bazel.
See also:
- DataDog/integrations-core#21652 2a47829
This aligns (up) the minimum supported macOS ABI to 11.0, as otherwise
[documented](https://docs.datadoghq.com/agent/supported_platforms/?tab=macos).

macOS ABI 10.x is no longer officially supported since Agent
[7.62.0](https://github.com/DataDog/datadog-agent/releases/tag/7.62.0)
(Jan 29, 2025).

There are multiple points of maintenance we'll centralize in the frame
of the ongoing migration to Bazel.
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/bump-minimum-supported-macos-abi-as-advertised branch from 4c38435 to 0f5f3ef Compare October 17, 2025 16:08
Copy link

@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this makes the behavior conform to the docs, we should consider mentioning that in the releasee notes as it changes undocumented behavior.

@rdesgroppes rdesgroppes changed the title Bump minimum supported macOS ABI as advertised Bump minimum supported macOS ABI as advertised (ABLD-28 follow-up) Oct 18, 2025
@rdesgroppes rdesgroppes added the qa/skip-qa Automatically skip this PR for the next QA label Oct 18, 2025
@DataDog DataDog deleted a comment from github-actions bot Oct 18, 2025
@rdesgroppes rdesgroppes added this pull request to the merge queue Oct 19, 2025
Merged via the queue into master with commit daccf8e Oct 19, 2025
48 of 50 checks passed
@rdesgroppes rdesgroppes deleted the regis.desgroppes/bump-minimum-supported-macos-abi-as-advertised branch October 19, 2025 16:00
@rdesgroppes
Copy link
Contributor Author

rdesgroppes commented Oct 20, 2025

Even though this makes the behavior conform to the docs, we should consider mentioning that in the releasee notes as it changes undocumented behavior.

@aiuto:

rdesgroppes added a commit to DataDog/datadog-agent that referenced this pull request Oct 21, 2025
….0 ABI (#42155)

### What does this PR do?
Clarify the advertised mininum ABI version is now observed by the
`x86_64` build of the Agent for macOS.

### Motivation
> Even though this makes the behavior conform to the docs, we should
consider mentioning that in the release notes as it changes undocumented
behavior.

(DataDog/integrations-core#21652 (review))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants