Skip to content

Conversation

@rdesgroppes
Copy link
Contributor

What does this PR do?

Clarify the advertised mininum ABI version is now observed by the x86_64 build of the Agent for macOS.

Motivation

Even though this makes the behavior conform to the docs, we should consider mentioning that in the release notes as it changes undocumented behavior.

(DataDog/integrations-core#21652 (review))

@rdesgroppes rdesgroppes requested a review from a team as a code owner October 20, 2025 17:15
@rdesgroppes rdesgroppes added qa/no-code-change No code change in Agent code requiring validation qa/skip-qa labels Oct 20, 2025
@rdesgroppes rdesgroppes requested a review from a team October 20, 2025 17:16
@rdesgroppes rdesgroppes added the ask-review Ask required teams to review this PR label Oct 20, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Oct 20, 2025
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Oct 20, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: cf93b438-f34b-41ad-9a16-96060dcc8a08

Baseline: 7faa429
Comparison: 78a2dfd
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_memory memory utilization -5.33 [-5.83, -4.83] 1 Logs

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -24.17 [-25.79, -22.55] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
ddot_metrics memory utilization +0.84 [+0.68, +1.00] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.70 [+0.62, +0.79] 1 Logs
quality_gate_idle memory utilization +0.58 [+0.54, +0.62] 1 Logs bounds checks dashboard
file_tree memory utilization +0.57 [+0.52, +0.62] 1 Logs
otlp_ingest_logs memory utilization +0.39 [+0.26, +0.52] 1 Logs
ddot_metrics_sum_delta memory utilization +0.38 [+0.23, +0.54] 1 Logs
quality_gate_idle_all_features memory utilization +0.21 [+0.17, +0.24] 1 Logs bounds checks dashboard
ddot_logs memory utilization +0.20 [+0.14, +0.27] 1 Logs
otlp_ingest_metrics memory utilization +0.06 [-0.07, +0.19] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.04 [-0.01, +0.08] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.21, +0.24] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.62, +0.60] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.63, +0.58] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.63, +0.58] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.07 [-0.69, +0.54] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.08 [-0.28, +0.12] 1 Logs
quality_gate_metrics_logs memory utilization -0.10 [-0.29, +0.10] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization -0.16 [-0.29, -0.03] 1 Logs
quality_gate_logs % cpu utilization -1.90 [-4.65, +0.85] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization -5.33 [-5.83, -4.83] 1 Logs
docker_containers_cpu % cpu utilization -24.17 [-25.79, -22.55] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 8/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Copy link
Contributor

@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But... srsly. We do release note building in yaml?

@buraizu buraizu self-assigned this Oct 20, 2025
@buraizu buraizu removed their assignment Oct 20, 2025
@rdesgroppes
Copy link
Contributor Author

But... srsly. We do release note building in yaml?

@aiuto yes, as documented: https://datadoghq.dev/datadog-agent/guidelines/contributing/#reno

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 20, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor f0e96fd

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${0}$$ $${675.79}$$ < $${702.15}$$ $${+0.02}$$ $${165.25}$$ < $${177.79}$$
agent_deb_amd64_fips $${0}$$ $${670.3}$$ < $${696.65}$$ $${+0.01}$$ $${164.81}$$ < $${176.53}$$
agent_heroku_amd64 $${0}$$ $${336.62}$$ < $${340.18}$$ $${-0}$$ $${89.83}$$ < $${91.08}$$
agent_msi $${0}$$ $${1013.76}$$ < $${1015.38}$$ $${+0.03}$$ $${148.44}$$ < $${150.78}$$
agent_rpm_amd64 $${0}$$ $${675.78}$$ < $${702.14}$$ $${+0.02}$$ $${167.44}$$ < $${180.53}$$
agent_rpm_amd64_fips $${0}$$ $${670.29}$$ < $${696.64}$$ $${+0}$$ $${166.14}$$ < $${178.79}$$
agent_rpm_arm64 $${0}$$ $${665.38}$$ < $${686.31}$$ $${-0.01}$$ $${153.39}$$ < $${161.22}$$
agent_rpm_arm64_fips $${0}$$ $${660.9}$$ < $${681.84}$$ $${+0.01}$$ $${153.09}$$ < $${160.18}$$
agent_suse_amd64 $${0}$$ $${675.78}$$ < $${702.14}$$ $${+0.02}$$ $${167.44}$$ < $${180.53}$$
agent_suse_amd64_fips $${0}$$ $${670.29}$$ < $${696.64}$$ $${+0}$$ $${166.14}$$ < $${178.79}$$
agent_suse_arm64 $${0}$$ $${665.38}$$ < $${686.31}$$ $${-0.01}$$ $${153.39}$$ < $${161.22}$$
agent_suse_arm64_fips $${0}$$ $${660.9}$$ < $${681.84}$$ $${+0.01}$$ $${153.09}$$ < $${160.18}$$
docker_agent_amd64 $${-0}$$ $${746.35}$$ < $${773.59}$$ $${+0}$$ $${251.85}$$ < $${266.06}$$
docker_agent_arm64 $${+0}$$ $${759.88}$$ < $${781.7}$$ $${+0}$$ $${242.46}$$ < $${251.85}$$
docker_agent_jmx_amd64 $${-0}$$ $${937.22}$$ < $${964.45}$$ $${-0}$$ $${320.49}$$ < $${334.68}$$
docker_agent_jmx_arm64 $${-0}$$ $${939.35}$$ < $${961.17}$$ $${+0}$$ $${307.08}$$ < $${316.44}$$
docker_cluster_agent_amd64 $${+0}$$ $${213.01}$$ < $${213.74}$$ $${+0}$$ $${72.26}$$ < $${73.14}$$
docker_cluster_agent_arm64 $${0}$$ $${228.92}$$ < $${229.68}$$ $${+0}$$ $${68.53}$$ < $${69.41}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${-0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${-0}$$ $${38.44}$$ < $${39.3}$$ $${-0}$$ $${14.84}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.12}$$ < $${37.94}$$ $${+0}$$ $${14.28}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.66}$$ < $${30.53}$$ $${+0}$$ $${7.82}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.25}$$ < $${29.11}$$ $${+0}$$ $${6.77}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.66}$$ < $${30.53}$$ $${-0}$$ $${7.83}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${0}$$ $${29.66}$$ < $${30.53}$$ $${-0}$$ $${7.83}$$ < $${8.76}$$
iot_agent_deb_amd64 $${0}$$ $${41.91}$$ < $${54.97}$$ $${+0}$$ $${10.9}$$ < $${14.45}$$
iot_agent_deb_arm64 $${0}$$ $${39.73}$$ < $${51.9}$$ $${-0}$$ $${9.42}$$ < $${12.63}$$
iot_agent_deb_armhf $${0}$$ $${39.6}$$ < $${51.84}$$ $${-0}$$ $${9.5}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${0}$$ $${41.92}$$ < $${54.97}$$ $${+0}$$ $${10.92}$$ < $${14.47}$$
iot_agent_suse_amd64 $${0}$$ $${41.92}$$ < $${54.97}$$ $${+0}$$ $${10.92}$$ < $${14.47}$$

@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/rebuilt-dependencies-now-uniformly-honor-macos-11.0-ABI-as-documented branch from b4bacd6 to 78a2dfd Compare October 20, 2025 23:16
@rdesgroppes rdesgroppes merged commit 5f0f544 into main Oct 21, 2025
244 checks passed
@rdesgroppes rdesgroppes deleted the regis.desgroppes/rebuilt-dependencies-now-uniformly-honor-macos-11.0-ABI-as-documented branch October 21, 2025 07:18
@github-actions github-actions bot added this to the 7.73.0 milestone Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR qa/no-code-change No code change in Agent code requiring validation qa/skip-qa short review PR is simple enough to be reviewed quickly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants