-
Notifications
You must be signed in to change notification settings - Fork 474
ci(profiling): add a clang-tidy check #15725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
a3dd31f to
8a97797
Compare
Performance SLOsComparing candidate kowalski/ci-profiling-add-a-clang-tidy-check (78a6467) with baseline main (c6edb37) ❌ Test Failures (1 suite)❌ iastaspects - 117/118✅ add_aspectTime: ✅ 18.090µs (SLO: <20.000µs -9.5%) vs baseline: 📈 +21.3% Memory: ✅ 42.762MB (SLO: <43.250MB 🟡 -1.1%) vs baseline: +5.0% ✅ add_inplace_aspectTime: ✅ 14.969µs (SLO: <20.000µs 📉 -25.2%) vs baseline: +0.4% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +5.1% ✅ add_inplace_noaspectTime: ✅ 0.341µs (SLO: <10.000µs 📉 -96.6%) vs baseline: +1.0% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ add_noaspectTime: ✅ 0.549µs (SLO: <10.000µs 📉 -94.5%) vs baseline: +0.4% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +3.8% ✅ bytearray_aspectTime: ✅ 18.046µs (SLO: <30.000µs 📉 -39.8%) vs baseline: -0.2% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.3% ✅ bytearray_extend_aspectTime: ✅ 24.020µs (SLO: <30.000µs 📉 -19.9%) vs baseline: +0.4% Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.2% ✅ bytearray_extend_noaspectTime: ✅ 2.711µs (SLO: <10.000µs 📉 -72.9%) vs baseline: -1.4% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.3% ✅ bytearray_noaspectTime: ✅ 1.460µs (SLO: <10.000µs 📉 -85.4%) vs baseline: -1.2% Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.0% ✅ bytes_aspectTime: ✅ 16.575µs (SLO: <20.000µs 📉 -17.1%) vs baseline: -0.7% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.5% ✅ bytes_noaspectTime: ✅ 1.407µs (SLO: <10.000µs 📉 -85.9%) vs baseline: -0.5% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.4% ✅ bytesio_aspectTime: ✅ 55.785µs (SLO: <70.000µs 📉 -20.3%) vs baseline: -0.1% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.3% ✅ bytesio_noaspectTime: ✅ 3.273µs (SLO: <10.000µs 📉 -67.3%) vs baseline: +0.1% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.0% ✅ capitalize_aspectTime: ✅ 14.710µs (SLO: <20.000µs 📉 -26.4%) vs baseline: +0.1% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +3.9% ✅ capitalize_noaspectTime: ✅ 2.603µs (SLO: <10.000µs 📉 -74.0%) vs baseline: ~same Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 14.748µs (SLO: <20.000µs 📉 -26.3%) vs baseline: -0.3% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.6% ✅ casefold_noaspectTime: ✅ 3.166µs (SLO: <10.000µs 📉 -68.3%) vs baseline: -0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.0% ✅ decode_aspectTime: ✅ 15.638µs (SLO: <30.000µs 📉 -47.9%) vs baseline: -0.1% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ decode_noaspectTime: ✅ 1.609µs (SLO: <10.000µs 📉 -83.9%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.2% ✅ encode_aspectTime: ✅ 18.205µs (SLO: <30.000µs 📉 -39.3%) vs baseline: 📈 +22.9% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ encode_noaspectTime: ✅ 1.489µs (SLO: <10.000µs 📉 -85.1%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ format_aspectTime: ✅ 171.044µs (SLO: <200.000µs 📉 -14.5%) vs baseline: ~same Memory: ✅ 42.762MB (SLO: <43.250MB 🟡 -1.1%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 191.347µs (SLO: <200.000µs -4.3%) vs baseline: +0.2% Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +3.8% ✅ format_map_noaspectTime: ✅ 3.834µs (SLO: <10.000µs 📉 -61.7%) vs baseline: +1.2% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.5% ✅ format_noaspectTime: ✅ 3.155µs (SLO: <10.000µs 📉 -68.5%) vs baseline: -0.3% Memory: ✅ 42.802MB (SLO: <43.250MB 🟡 -1.0%) vs baseline: +4.6% ✅ index_aspectTime: ✅ 15.342µs (SLO: <20.000µs 📉 -23.3%) vs baseline: -0.8% Memory: ✅ 42.762MB (SLO: <43.250MB 🟡 -1.1%) vs baseline: +5.0% ✅ index_noaspectTime: ✅ 0.465µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.4% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ join_aspectTime: ✅ 17.025µs (SLO: <20.000µs 📉 -14.9%) vs baseline: -0.6% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.1% ✅ join_noaspectTime: ✅ 1.545µs (SLO: <10.000µs 📉 -84.5%) vs baseline: -0.9% Memory: ✅ 42.684MB (SLO: <43.250MB 🟡 -1.3%) vs baseline: +4.1% ✅ ljust_aspectTime: ✅ 20.823µs (SLO: <30.000µs 📉 -30.6%) vs baseline: -0.5% Memory: ✅ 42.546MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.1% ✅ ljust_noaspectTime: ✅ 2.704µs (SLO: <10.000µs 📉 -73.0%) vs baseline: +0.4% Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +3.9% ✅ lower_aspectTime: ✅ 18.012µs (SLO: <30.000µs 📉 -40.0%) vs baseline: +0.8% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.1% ✅ lower_noaspectTime: ✅ 2.425µs (SLO: <10.000µs 📉 -75.7%) vs baseline: ~same Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.2% ✅ lstrip_aspectTime: ✅ 17.612µs (SLO: <20.000µs 📉 -11.9%) vs baseline: -0.3% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.8% ✅ lstrip_noaspectTime: ✅ 1.860µs (SLO: <10.000µs 📉 -81.4%) vs baseline: -0.7% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +3.9% ✅ modulo_aspectTime: ✅ 166.136µs (SLO: <200.000µs 📉 -16.9%) vs baseline: -0.4% Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 174.771µs (SLO: <200.000µs 📉 -12.6%) vs baseline: -0.3% Memory: ✅ 42.900MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.5% ✅ modulo_aspect_for_bytesTime: ✅ 168.489µs (SLO: <200.000µs 📉 -15.8%) vs baseline: ~same Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 171.859µs (SLO: <200.000µs 📉 -14.1%) vs baseline: -0.2% Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.0% ✅ modulo_noaspectTime: ✅ 3.800µs (SLO: <10.000µs 📉 -62.0%) vs baseline: +4.0% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.3% ✅ replace_aspectTime: ✅ 212.193µs (SLO: <300.000µs 📉 -29.3%) vs baseline: ~same Memory: ✅ 43.155MB (SLO: <44.000MB 🟡 -1.9%) vs baseline: +4.8% ✅ replace_noaspectTime: ✅ 2.911µs (SLO: <10.000µs 📉 -70.9%) vs baseline: +0.5% Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.3% ✅ repr_aspectTime: ✅ 1.426µs (SLO: <10.000µs 📉 -85.7%) vs baseline: +0.1% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.7% ✅ repr_noaspectTime: ✅ 0.530µs (SLO: <10.000µs 📉 -94.7%) vs baseline: ~same Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.3% ✅ rstrip_aspectTime: ✅ 19.032µs (SLO: <30.000µs 📉 -36.6%) vs baseline: -0.3% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.6% ✅ rstrip_noaspectTime: ✅ 2.048µs (SLO: <10.000µs 📉 -79.5%) vs baseline: +5.4% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.0% ✅ slice_aspectTime: ✅ 15.882µs (SLO: <20.000µs 📉 -20.6%) vs baseline: -0.2% Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ slice_noaspectTime: ✅ 0.598µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.2% Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.4% ✅ stringio_aspectTime: ✅ 54.218µs (SLO: <80.000µs 📉 -32.2%) vs baseline: +0.3% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.4% ✅ stringio_noaspectTime: ✅ 3.621µs (SLO: <10.000µs 📉 -63.8%) vs baseline: -0.8% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.1% ✅ strip_aspectTime: ✅ 17.571µs (SLO: <20.000µs 📉 -12.1%) vs baseline: -0.6% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.6% ✅ strip_noaspectTime: ✅ 1.866µs (SLO: <10.000µs 📉 -81.3%) vs baseline: +0.1% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +3.9% ✅ swapcase_aspectTime: ✅ 18.510µs (SLO: <30.000µs 📉 -38.3%) vs baseline: +0.3% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ swapcase_noaspectTime: ✅ 2.806µs (SLO: <10.000µs 📉 -71.9%) vs baseline: ~same Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.0% ❌ title_aspectTime: ❌ 22.188µs (SLO: <20.000µs 📈 +10.9%) vs baseline: 📈 +21.3% Memory: ✅ 42.605MB (SLO: <43.000MB 🟡 -0.9%) vs baseline: +4.0% ✅ title_noaspectTime: ✅ 2.664µs (SLO: <10.000µs 📉 -73.4%) vs baseline: -0.1% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.0% ✅ translate_aspectTime: ✅ 20.453µs (SLO: <30.000µs 📉 -31.8%) vs baseline: -0.9% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.7% ✅ translate_noaspectTime: ✅ 4.348µs (SLO: <10.000µs 📉 -56.5%) vs baseline: +0.3% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.3% ✅ upper_aspectTime: ✅ 17.987µs (SLO: <30.000µs 📉 -40.0%) vs baseline: ~same Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ upper_noaspectTime: ✅ 2.428µs (SLO: <10.000µs 📉 -75.7%) vs baseline: -0.2% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +3.9% 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.156µs (SLO: <10.000µs 📉 -48.4%) vs baseline: 📈 +21.6% Memory: ✅ 41.347MB (SLO: <43.500MB -5.0%) vs baseline: +4.8% ✅ ospathbasename_noaspectTime: ✅ 4.289µs (SLO: <10.000µs 📉 -57.1%) vs baseline: ~same Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.7% ✅ ospathjoin_aspectTime: ✅ 6.232µs (SLO: <10.000µs 📉 -37.7%) vs baseline: -0.8% Memory: ✅ 41.504MB (SLO: <43.500MB -4.6%) vs baseline: +5.3% ✅ ospathjoin_noaspectTime: ✅ 6.308µs (SLO: <10.000µs 📉 -36.9%) vs baseline: -0.6% Memory: ✅ 41.347MB (SLO: <43.500MB -5.0%) vs baseline: +4.7% ✅ ospathnormcase_aspectTime: ✅ 3.585µs (SLO: <10.000µs 📉 -64.2%) vs baseline: +0.8% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathnormcase_noaspectTime: ✅ 3.635µs (SLO: <10.000µs 📉 -63.7%) vs baseline: ~same Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 4.906µs (SLO: <10.000µs 📉 -50.9%) vs baseline: +0.8% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 5.026µs (SLO: <10.000µs 📉 -49.7%) vs baseline: +0.2% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 3.750µs (SLO: <10.000µs 📉 -62.5%) vs baseline: -0.3% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.751µs (SLO: <10.000µs 📉 -92.5%) vs baseline: +0.6% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.623µs (SLO: <10.000µs 📉 -53.8%) vs baseline: +0.6% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.9% ✅ ospathsplitext_noaspectTime: ✅ 4.626µs (SLO: <10.000µs 📉 -53.7%) vs baseline: -0.2% Memory: ✅ 41.347MB (SLO: <43.500MB -5.0%) vs baseline: +4.7% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.402µs (SLO: <20.000µs 📉 -83.0%) vs baseline: 📈 +14.4% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 198.960µs (SLO: <220.000µs -9.6%) vs baseline: +0.2% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ 1-distribution-metric-1-timesTime: ✅ 3.304µs (SLO: <20.000µs 📉 -83.5%) vs baseline: -1.2% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.0% ✅ 1-distribution-metrics-100-timesTime: ✅ 214.265µs (SLO: <230.000µs -6.8%) vs baseline: -0.4% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.2% ✅ 1-gauge-metric-1-timesTime: ✅ 2.192µs (SLO: <20.000µs 📉 -89.0%) vs baseline: ~same Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.958µs (SLO: <150.000µs -9.4%) vs baseline: ~same Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.146µs (SLO: <20.000µs 📉 -84.3%) vs baseline: ~same Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.8% ✅ 1-rate-metrics-100-timesTime: ✅ 213.099µs (SLO: <250.000µs 📉 -14.8%) vs baseline: +0.3% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 19.850ms (SLO: <22.000ms -9.8%) vs baseline: -0.3% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.238ms (SLO: <2.550ms 📉 -12.2%) vs baseline: +0.8% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.412ms (SLO: <1.550ms -8.9%) vs baseline: +1.1% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ 100-rate-metrics-100-timesTime: ✅ 2.185ms (SLO: <2.550ms 📉 -14.3%) vs baseline: +0.7% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.539µs (SLO: <20.000µs 📉 -77.3%) vs baseline: +0.4% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.5% ✅ flush-100-metricsTime: ✅ 173.564µs (SLO: <250.000µs 📉 -30.6%) vs baseline: +0.6% Memory: ✅ 35.193MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +5.2% ✅ flush-1000-metricsTime: ✅ 2.169ms (SLO: <2.500ms 📉 -13.2%) vs baseline: -0.2% Memory: ✅ 36.078MB (SLO: <36.500MB 🟡 -1.2%) vs baseline: +4.9% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
96e5876 to
19c34f8
Compare
19c34f8 to
78a6467
Compare
Description
Testing
Risks
Additional Notes