-
Notifications
You must be signed in to change notification settings - Fork 14
add api10 test for redirection with status code analysis #5831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cbeauchesne
merged 6 commits into
main
from
christophe-papazian/api10_redirection_status_code
Dec 8, 2025
Merged
add api10 test for redirection with status code analysis #5831
cbeauchesne
merged 6 commits into
main
from
christophe-papazian/api10_redirection_status_code
Dec 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
IlyasShabi
reviewed
Dec 8, 2025
christophe-papazian
added a commit
to DataDog/dd-trace-py
that referenced
this pull request
Dec 8, 2025
## Description Add redirection response waf analysis both to urllib and urllib3 ## Testing This will be tested by DataDog/system-tests#5831 APPSEC-60065
…ithub.com:DataDog/system-tests into christophe-papazian/api10_redirection_status_code
…pi10_redirection_status_code
IlyasShabi
approved these changes
Dec 8, 2025
brettlangdon
pushed a commit
to DataDog/dd-trace-py
that referenced
this pull request
Dec 8, 2025
## Description Add redirection response waf analysis both to urllib and urllib3 ## Testing This will be tested by DataDog/system-tests#5831 APPSEC-60065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previous api10 test for redirection didn't check for response analysis.
This one does.
A new static rule is used that will add a meta tag if a redirection is detected in the response analysis. This should ensure that redirection headers and status code are properly analyzed by the tracers.
APPSEC-60065
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present