Skip to content

Conversation

@christophe-papazian
Copy link
Contributor

@christophe-papazian christophe-papazian commented Dec 5, 2025

Motivation

Previous api10 test for redirection didn't check for response analysis.
This one does.

A new static rule is used that will add a meta tag if a redirection is detected in the response analysis. This should ensure that redirection headers and status code are properly analyzed by the tracers.

APPSEC-60065

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

CODEOWNERS have been resolved as:

manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
manifests/nodejs.yml                                                    @DataDog/dd-trace-js
manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php
manifests/python.yml                                                    @DataDog/apm-python @DataDog/asm-python
manifests/python_lambda.yml                                             @DataDog/system-tests-core
manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby
tests/appsec/rasp/rasp_non_blocking_ruleset.json                        @DataDog/asm-libraries @DataDog/system-tests-core
tests/appsec/rasp/test_api10.py                                         @DataDog/asm-libraries @DataDog/system-tests-core
utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core
utils/_context/_scenarios/appsec_rasp.py                                @DataDog/system-tests-core

christophe-papazian added a commit to DataDog/dd-trace-py that referenced this pull request Dec 8, 2025
## Description

Add redirection response waf analysis both to urllib and urllib3

## Testing

This will be tested by DataDog/system-tests#5831

APPSEC-60065
…ithub.com:DataDog/system-tests into christophe-papazian/api10_redirection_status_code
@cbeauchesne cbeauchesne merged commit 94529f6 into main Dec 8, 2025
2591 of 2597 checks passed
@cbeauchesne cbeauchesne deleted the christophe-papazian/api10_redirection_status_code branch December 8, 2025 13:35
brettlangdon pushed a commit to DataDog/dd-trace-py that referenced this pull request Dec 8, 2025
## Description

Add redirection response waf analysis both to urllib and urllib3

## Testing

This will be tested by DataDog/system-tests#5831

APPSEC-60065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants