Added command line option for UDP connection to autopilot #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added command-line options to specify which protocol to use, with sane defaults. Signed-off-by: Mark Charlebois <[email protected]>
Fixed issue with opening port, and adjusted command-line parsing. UDP support should now be functional and selectable as a command line option. Signed-off-by: Mark Charlebois <[email protected]>
Owner
|
It would be very useful if it was only option to configure, but there are a lot of other options that still need to be hardcoded. But I think how to remove this hardcoding. What about configuration file? But it will be complicated and parsing will be also not easy. Anyway I will think how to move something to arguments. |
|
Hi Anton, what hardcoded options are you concerned about? Mainly the IP addresses? I made another change to allow those to be command-line arguments as well. I am still testing that, but it could be a good option. Let me know what you would like to be a command-line argument. |
Added ability to specify IP address on the command-line, and turn off messages being sent to QGC Signed-off-by: Mark Charlebois <[email protected]>
Use the external network interface not loopback for sending. Passing in an IP address as a command argument now works. Signed-off-by: Mark Charlebois <[email protected]>
Owner
|
Not only IP addresses but also camera configuration, vehicle mass, moment of inertia, rotors parameters etc, etc... It's all configurable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been tested with QGC and a version of PX4 running in a SITL setup.