Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr won't be merged in current state. As we discussed in Zulip giving that much control over sun color/position to UI may have some consequences. E.g. too many "fancy" clownlike presets shared via UI mods and then showed on streams, that may scare away new players and also upset mapmakers. So best thing we can do is make 4-5 presets (early morning, noontime, sunset, cloudy weather etc.) hardcoded in engine and then let user to switch between them.
For now all functions are available in UI, so we can find best values for presets which looks ok on common maps (like Setons, Gap etc). Ui functions:
Some examples on seton: