_Constant audit
#5142
Open
_Constant audit
#5142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
`Constant` IR op needs the frontend to be audited and pass padding information through.
`ThreadRemoveCodeEntry` doesn't properly have relations wired up but it does use the Entry. So this would be broken on code caching with relocations.
All direct usages have been audited. Now we need to do indirect usages through the `Constant` IR operation.
Kind of annoying that it is overlapping with LoadConstant. NFC
Fixes an issue that a potential same constant could be padded for one use and not padded for another.
`MOVGPRImmediate` is changing in another PR and we need to come back to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #5140 merged first.
This audits the direct usage of the
_ConstantIR op. The IREmitter constant pool is required to track padding and maxbytes to ensure no incorrect padding usage slips through the pool.This leaves the biggest audit remaining, anything that uses the IREmitter pool which is just called
Constant(...)which will take quite a bit longer to go through all use cases.