-
Notifications
You must be signed in to change notification settings - Fork 223
WIP: [cmake] allow fetching deps with CPM instead of submodules #5159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Extremely WIP, thunks and tests are untested since I don't have an aarch64 development environment on me at the time. Will document this later. Signed-off-by: crueter <[email protected]>
|
I'm not sure how I feel about this one yet. |
|
I'll document more thoroughly when I actually finish it, but the gist is
|
| shallow = true | ||
| path = External/robin-map | ||
| url = https://github.com/FEX-Emu/robin-map.git | ||
| url = https://github.com/crueter/robin-map.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh, it'd be nice if we could track the main repo for robin-map, especially since it seems that we're 2 minor versions behind now (i.e. 1.2.1, but 1.4.1 is out, which does seem to have some performance improvements, though small, and also unbreaks systems using CMake 4.0+)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have one patch on top of upstream so we can't track upstream. FEX-Emu/robin-map@d5683d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, bleh. I guess in that case it would be good to reapply on top of the latest release then (if possible), so we don't have an eventual build break
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest I wish we could just use something like unordered_dense instead
In CPM land, applying patches is as simple as creating a patch and applying it with the PATCHES option. That's another benefit of using it over submodules.
|
This needs a lot more time to bake, so I'm closing it for now and keeping it as a future reference. Self-notes:
|
Port of FEX-Emu#5159 Find modules are preferred for pkgconfig/otherwise non-CMake libraries. Let's use that here for xxHash. Signed-off-by: crueter <[email protected]>
Port of FEX-Emu#5159 Find modules are preferred for pkgconfig/otherwise non-CMake libraries. Let's use that here for xxHash. Signed-off-by: crueter <[email protected]>
Port of FEX-Emu#5159 Find modules are preferred for pkgconfig/otherwise non-CMake libraries. Let's use that here for xxHash. Signed-off-by: crueter <[email protected]>
Port of FEX-Emu#5159 Find modules are preferred for pkgconfig/otherwise non-CMake libraries. Let's use that here for xxHash. Signed-off-by: crueter <[email protected]>
Extremely WIP, thunks and tests are untested since I don't have an aarch64 development environment on me at the time. Will document this later.
Main TODOs:
Signed-off-by: crueter [email protected]