Inline search modal #3416
Open
Inline search modal #3416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8a310e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
SamyPesse
reviewed
Jul 3, 2025
packages/gitbook/src/components/RootLayout/CustomizationRootLayout.tsx
Outdated
Show resolved
Hide resolved
packages/gitbook/src/components/TableOfContents/TableOfContents.tsx
Outdated
Show resolved
Hide resolved
In summary: every time we'd type in the input, the browser would try to scroll to the input. But because the input is shown _above_ the scrollview's `scroll-padding-top`, it jumped up a tiny bit with every character typed. Instead of attaching a `scroll-padding` to the viewport, we now have a `scroll-margin` on elements we're actually scrolling to. This was even in place already, so took no extra effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.