-
Notifications
You must be signed in to change notification settings - Fork 4k
Inline search modal #3416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zenoachtig
wants to merge
32
commits into
main
Choose a base branch
from
zeno/rnd-7437-inline-search-modal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+795
−930
Open
Inline search modal #3416
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
9d8f251
Initial try-out
zenoachtig e822a53
Cleanup
zenoachtig d7ab5d9
Style results
zenoachtig 27dc51e
Tweak styling of non-ask empty state
zenoachtig 41953a9
Get ask working
zenoachtig 4f2bf71
Cleanup
zenoachtig 1f28b52
Make sidebar-only mode work better
zenoachtig 7a9b8a6
Fix some focus bugs
zenoachtig 6d65312
Standardise header button style
zenoachtig 60f0a44
Tweaks and tests
zenoachtig 685a838
Fix mobile input
zenoachtig f06b193
Add search scope toggle
zenoachtig 6225caa
Properly hide searchtoggle when not multivariants
zenoachtig 72ebee4
Fix input focus, add clear button
zenoachtig 1f01cff
Theme-bold input colors
zenoachtig ce25651
Tweaks to popover showing
zenoachtig d2446f4
Change button to div to prevent nested interactive elements
zenoachtig 120ac7a
Typecheck
zenoachtig 2ec9bbf
Fix search input sizing
zenoachtig 1aa0f62
Changeset
zenoachtig 4e5590a
Merge branch 'main' into zeno/rnd-7437-inline-search-modal
zenoachtig 7a728a9
Merge branch 'main' into zeno/rnd-7437-inline-search-modal
zenoachtig 3c38835
Use `ai.mode` instead of `aiSearch.enabled`
zenoachtig 8e4d45e
Review
zenoachtig 29c43ba
Update SearchInput.tsx
zenoachtig 1b3fa96
Improve state management
zenoachtig 2d25257
Improve clear button
zenoachtig cc4bdc5
Update SearchInput.tsx
zenoachtig 25dba09
Fix scroll-padding issue
zenoachtig 8a310e5
Fix empty search state not launching on page load
zenoachtig 7cbe709
Review comments
zenoachtig 928a541
Merge branch 'main' into zeno/rnd-7437-inline-search-modal
zenoachtig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"gitbook": minor | ||
--- | ||
|
||
New search layout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,3 @@ | ||
export * from './AIChat'; | ||
export * from './AIChatButton'; | ||
export * from './AIChatIcon'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
144 changes: 0 additions & 144 deletions
144
packages/gitbook/src/components/Search/SearchButton.tsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.