Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to old nodejs runtimes in Cloud Functions #13321

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented Mar 11, 2025

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@slevenick slevenick changed the title Remove references to nodejs12 Remove references to old nodejs runtimes in Cloud Functions Mar 11, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 43 insertions(+), 43 deletions(-))
google-beta provider: Diff ( 15 files changed, 47 insertions(+), 47 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 43 insertions(+), 43 deletions(-))
google-beta provider: Diff ( 15 files changed, 47 insertions(+), 47 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1250
Passed tests: 1142
Skipped tests: 85
Affected tests: 23

Click here to see the affected service packages
  • cloudfunctions
  • cloudfunctions2
  • compute
  • firebasehosting
  • monitoring

Action taken

Found 23 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudFunctions2Function_fullUpdate
  • TestAccCloudfunctions2functionIamBindingGenerated
  • TestAccCloudfunctions2functionIamMemberGenerated
  • TestAccCloudfunctions2functionIamPolicyGenerated
  • TestAccCloudfunctions2function_cloudfunctions2AbiuExample
  • TestAccCloudfunctions2function_cloudfunctions2AbiuOnDeployExample
  • TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample
  • TestAccCloudfunctions2function_cloudfunctions2BasicBuilderExample
  • TestAccCloudfunctions2function_cloudfunctions2BasicExample
  • TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample
  • TestAccCloudfunctions2function_cloudfunctions2FullExample
  • TestAccCloudfunctions2function_cloudfunctions2PrivateWorkerpoolExample
  • TestAccCloudfunctions2function_cloudfunctions2SecretEnvExample
  • TestAccCloudfunctions2function_cloudfunctions2SecretVolumeExample
  • TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample
  • TestAccFirebaseHostingVersion_firebasehostingVersionCloudFunctionsExample
  • TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigSyntheticMonitorExample
  • TestAccCloudFunctionsCloudFunctionIamBindingGenerated
  • TestAccCloudFunctionsCloudFunctionIamMemberGenerated
  • TestAccCloudFunctionsCloudFunctionIamPolicyGenerated
  • TestAccCloudFunctionsFunction_secretEnvVar
  • TestAccCloudFunctionsFunction_secretMount
  • TestAccDataSourceGoogleCloudFunctionsFunction_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1250
Passed tests: 1142
Skipped tests: 85
Affected tests: 23

Click here to see the affected service packages
  • monitoring
  • cloudfunctions
  • cloudfunctions2
  • compute
  • firebasehosting

Action taken

Found 23 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudFunctionsCloudFunctionIamBindingGenerated
  • TestAccCloudFunctionsCloudFunctionIamMemberGenerated
  • TestAccCloudFunctionsCloudFunctionIamPolicyGenerated
  • TestAccCloudFunctionsFunction_secretEnvVar
  • TestAccCloudFunctionsFunction_secretMount
  • TestAccDataSourceGoogleCloudFunctionsFunction_basic
  • TestAccCloudFunctions2Function_fullUpdate
  • TestAccCloudfunctions2functionIamBindingGenerated
  • TestAccCloudfunctions2functionIamMemberGenerated
  • TestAccCloudfunctions2functionIamPolicyGenerated
  • TestAccCloudfunctions2function_cloudfunctions2AbiuExample
  • TestAccCloudfunctions2function_cloudfunctions2AbiuOnDeployExample
  • TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample
  • TestAccCloudfunctions2function_cloudfunctions2BasicBuilderExample
  • TestAccCloudfunctions2function_cloudfunctions2BasicExample
  • TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample
  • TestAccCloudfunctions2function_cloudfunctions2FullExample
  • TestAccCloudfunctions2function_cloudfunctions2PrivateWorkerpoolExample
  • TestAccCloudfunctions2function_cloudfunctions2SecretEnvExample
  • TestAccCloudfunctions2function_cloudfunctions2SecretVolumeExample
  • TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample
  • TestAccFirebaseHostingVersion_firebasehostingVersionCloudFunctionsExample
  • TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigSyntheticMonitorExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1250
Passed tests: 1142
Skipped tests: 85
Affected tests: 23

Click here to see the affected service packages
  • cloudfunctions2
  • compute
  • firebasehosting
  • monitoring
  • cloudfunctions

Action taken

Found 23 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudFunctionsCloudFunctionIamBindingGenerated
  • TestAccCloudFunctionsCloudFunctionIamMemberGenerated
  • TestAccCloudFunctionsCloudFunctionIamPolicyGenerated
  • TestAccCloudFunctionsFunction_secretEnvVar
  • TestAccCloudFunctionsFunction_secretMount
  • TestAccDataSourceGoogleCloudFunctionsFunction_basic
  • TestAccCloudFunctions2Function_fullUpdate
  • TestAccCloudfunctions2functionIamBindingGenerated
  • TestAccCloudfunctions2functionIamMemberGenerated
  • TestAccCloudfunctions2functionIamPolicyGenerated
  • TestAccCloudfunctions2function_cloudfunctions2AbiuExample
  • TestAccCloudfunctions2function_cloudfunctions2AbiuOnDeployExample
  • TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample
  • TestAccCloudfunctions2function_cloudfunctions2BasicBuilderExample
  • TestAccCloudfunctions2function_cloudfunctions2BasicExample
  • TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample
  • TestAccCloudfunctions2function_cloudfunctions2FullExample
  • TestAccCloudfunctions2function_cloudfunctions2PrivateWorkerpoolExample
  • TestAccCloudfunctions2function_cloudfunctions2SecretEnvExample
  • TestAccCloudfunctions2function_cloudfunctions2SecretVolumeExample
  • TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample
  • TestAccFirebaseHostingVersion_firebasehostingVersionCloudFunctionsExample
  • TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigSyntheticMonitorExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudFunctions2Function_fullUpdate [Debug log]
TestAccCloudFunctionsCloudFunctionIamBindingGenerated [Debug log]
TestAccCloudFunctionsCloudFunctionIamMemberGenerated [Debug log]
TestAccCloudFunctionsCloudFunctionIamPolicyGenerated [Debug log]
TestAccCloudFunctionsFunction_secretEnvVar [Debug log]
TestAccCloudFunctionsFunction_secretMount [Debug log]
TestAccCloudfunctions2functionIamBindingGenerated [Debug log]
TestAccCloudfunctions2functionIamMemberGenerated [Debug log]
TestAccCloudfunctions2functionIamPolicyGenerated [Debug log]
TestAccCloudfunctions2function_cloudfunctions2AbiuExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2AbiuOnDeployExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicBuilderExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2FullExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2PrivateWorkerpoolExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2SecretEnvExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2SecretVolumeExample [Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample [Debug log]
TestAccDataSourceGoogleCloudFunctionsFunction_basic [Debug log]
TestAccFirebaseHostingVersion_firebasehostingVersionCloudFunctionsExample [Debug log]
TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigSyntheticMonitorExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudFunctions2Function_fullUpdate [Debug log]
TestAccCloudFunctionsCloudFunctionIamBindingGenerated [Debug log]
TestAccCloudFunctionsCloudFunctionIamMemberGenerated [Debug log]
TestAccCloudFunctionsCloudFunctionIamPolicyGenerated [Debug log]
TestAccCloudFunctionsFunction_secretEnvVar [Debug log]
TestAccCloudFunctionsFunction_secretMount [Debug log]
TestAccCloudfunctions2functionIamBindingGenerated [Debug log]
TestAccCloudfunctions2functionIamMemberGenerated [Debug log]
TestAccCloudfunctions2functionIamPolicyGenerated [Debug log]
TestAccCloudfunctions2function_cloudfunctions2AbiuExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2AbiuOnDeployExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicBuilderExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2FullExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2PrivateWorkerpoolExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2SecretEnvExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2SecretVolumeExample [Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample [Debug log]
TestAccDataSourceGoogleCloudFunctionsFunction_basic [Debug log]
TestAccFirebaseHostingVersion_firebasehostingVersionCloudFunctionsExample [Debug log]
TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigSyntheticMonitorExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudFunctions2Function_fullUpdate [Debug log]
TestAccCloudFunctionsCloudFunctionIamBindingGenerated [Debug log]
TestAccCloudFunctionsCloudFunctionIamMemberGenerated [Debug log]
TestAccCloudFunctionsCloudFunctionIamPolicyGenerated [Debug log]
TestAccCloudFunctionsFunction_secretEnvVar [Debug log]
TestAccCloudFunctionsFunction_secretMount [Debug log]
TestAccCloudfunctions2functionIamBindingGenerated [Debug log]
TestAccCloudfunctions2functionIamMemberGenerated [Debug log]
TestAccCloudfunctions2functionIamPolicyGenerated [Debug log]
TestAccCloudfunctions2function_cloudfunctions2AbiuExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2AbiuOnDeployExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicBuilderExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2FullExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2PrivateWorkerpoolExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2SecretEnvExample [Debug log]
TestAccCloudfunctions2function_cloudfunctions2SecretVolumeExample [Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample [Debug log]
TestAccDataSourceGoogleCloudFunctionsFunction_basic [Debug log]
TestAccFirebaseHostingVersion_firebasehostingVersionCloudFunctionsExample [Debug log]
TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigSyntheticMonitorExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@slevenick slevenick requested review from a team and NickElliot and removed request for a team March 11, 2025 16:31
Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment