-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to old nodejs runtimes in Cloud Functions #13321
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1250 Click here to see the affected service packages
Action takenFound 23 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 1250 Click here to see the affected service packages
Action takenFound 23 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 1250 Click here to see the affected service packages
Action takenFound 23 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9156ea5
This is causing errors in tests now due to deprecation. Switching to nodejs20 which is supported into 2026: https://cloud.google.com/functions/docs/runtime-support
Fixes: hashicorp/terraform-provider-google#21803
Fixes: hashicorp/terraform-provider-google#21802
Fixes: hashicorp/terraform-provider-google#21801
Fixes: hashicorp/terraform-provider-google#21799
Fixes: hashicorp/terraform-provider-google#21800
Fixes: hashicorp/terraform-provider-google#21798
Also:
Fixes: hashicorp/terraform-provider-google#21794
Fixes: hashicorp/terraform-provider-google#21793
Fixes: hashicorp/terraform-provider-google#21792
Fixes: hashicorp/terraform-provider-google#21796
Fixes: hashicorp/terraform-provider-google#21797
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.