Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to old nodejs runtimes in Cloud Functions #13321

Merged
merged 3 commits into from
Mar 11, 2025
Merged

Remove references to old nodejs runtimes in Cloud Functions #13321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0f3a03
Remove references to nodejs12 as it seems to be deprecated
slevenick Mar 11, 2025
aeb8ca4
Update deprecated references to nodejs
slevenick Mar 11, 2025
3047c0e
Update nodejs16 as well
slevenick Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/examples/cloudfunctions2_abiu.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ resource "google_cloudfunctions2_function" "{{$.PrimaryResourceId}}" {
description = "a new function"

build_config {
runtime = "nodejs16"
runtime = "nodejs20"
entry_point = "helloPubSub" # Set the entry point
environment_variables = {
BUILD_CONFIG_TEST = "build_test"
Expand Down
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/examples/cloudfunctions2_abiu_on_deploy.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ resource "google_cloudfunctions2_function" "{{$.PrimaryResourceId}}" {
description = "a new function"

build_config {
runtime = "nodejs16"
runtime = "nodejs20"
entry_point = "helloPubSub" # Set the entry point
environment_variables = {
BUILD_CONFIG_TEST = "build_test"
Expand Down
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/examples/cloudfunctions2_basic.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ resource "google_cloudfunctions2_function" "{{$.PrimaryResourceId}}" {
description = "a new function"

build_config {
runtime = "nodejs16"
runtime = "nodejs20"
entry_point = "helloHttp" # Set the entry point
source {
storage_source {
Expand Down
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/examples/cloudfunctions2_basic_auditlogs.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ resource "google_cloudfunctions2_function" "{{$.PrimaryResourceId}}" {
description = "a new function"

build_config {
runtime = "nodejs12"
runtime = "nodejs20"
entry_point = "entryPoint" # Set the entry point in the code
environment_variables = {
BUILD_CONFIG_TEST = "build_test"
Expand Down
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/examples/cloudfunctions2_basic_builder.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ resource "google_cloudfunctions2_function" "{{$.PrimaryResourceId}}" {
description = "a new function"

build_config {
runtime = "nodejs16"
runtime = "nodejs20"
entry_point = "helloHttp" # Set the entry point
source {
storage_source {
Expand Down
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/examples/cloudfunctions2_basic_gcs.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ resource "google_cloudfunctions2_function" "{{$.PrimaryResourceId}}" {
description = "a new function"

build_config {
runtime = "nodejs12"
runtime = "nodejs20"
entry_point = "entryPoint" # Set the entry point in the code
environment_variables = {
BUILD_CONFIG_TEST = "build_test"
Expand Down
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/examples/cloudfunctions2_cmek.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ resource "google_cloudfunctions2_function" "{{$.PrimaryResourceId}}" {
kms_key_name = "{{index $.Vars "kms_key_name"}}"

build_config {
runtime = "nodejs16"
runtime = "nodejs20"
entry_point = "helloHttp" # Set the entry point
docker_repository = google_artifact_registry_repository.encoded-ar-repo.id

Expand Down
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/examples/cloudfunctions2_cmek_docs.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ resource "google_cloudfunctions2_function" "{{$.PrimaryResourceId}}" {
kms_key_name = "{{index $.Vars "kms_key_name"}}"

build_config {
runtime = "nodejs16"
runtime = "nodejs20"
entry_point = "helloHttp" # Set the entry point
docker_repository = google_artifact_registry_repository.encoded-ar-repo.id

Expand Down
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/examples/cloudfunctions2_full.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ resource "google_cloudfunctions2_function" "{{$.PrimaryResourceId}}" {
description = "a new function"

build_config {
runtime = "nodejs16"
runtime = "nodejs20"
entry_point = "helloPubSub" # Set the entry point
environment_variables = {
BUILD_CONFIG_TEST = "build_test"
Expand Down
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/examples/cloudfunctions2_private_workerpool.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ resource "google_cloudfunctions2_function" "{{$.PrimaryResourceId}}" {
description = "a new function"

build_config {
runtime = "nodejs16"
runtime = "nodejs20"
entry_point = "helloHttp" # Set the entry point
source {
storage_source {
Expand Down
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/examples/cloudfunctions2_scheduler_auth.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ resource "google_cloudfunctions2_function" "{{$.PrimaryResourceId}}" {
description = "a new function"

build_config {
runtime = "nodejs16"
runtime = "nodejs20"
entry_point = "helloHttp" # Set the entry point
source {
storage_source {
Expand Down
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/examples/cloudfunctions2_secret_env.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ resource "google_cloudfunctions2_function" "{{$.PrimaryResourceId}}" {
description = "a new function"

build_config {
runtime = "nodejs16"
runtime = "nodejs20"
entry_point = "helloHttp" # Set the entry point
source {
storage_source {
Expand Down
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/examples/cloudfunctions2_secret_volume.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ resource "google_cloudfunctions2_function" "{{$.PrimaryResourceId}}" {
description = "a new function"

build_config {
runtime = "nodejs16"
runtime = "nodejs20"
entry_point = "helloHttp" # Set the entry point
source {
storage_source {
Expand Down
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/examples/cloudfunctions_cloud_function.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ resource "google_storage_bucket_object" "archive" {
resource "google_cloudfunctions_function" "{{$.PrimaryResourceId}}" {
name = "{{index $.Vars "function_name"}}"
description = "My function"
runtime = "nodejs10"
runtime = "nodejs20"

available_memory_mb = 128
source_archive_bucket = google_storage_bucket.bucket.name
Expand Down
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/examples/firebasehosting_version_cloud_functions.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ resource "google_cloudfunctions_function" "function" {

name = "{{index $.Vars "cloud_function_id"}}"
description = "A Cloud Function connected to Firebase Hosing"
runtime = "nodejs16"
runtime = "nodejs20"

available_memory_mb = 128
source_archive_bucket = google_storage_bucket.bucket.name
Expand Down
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/examples/region_network_endpoint_group_functions.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ resource "google_compute_region_network_endpoint_group" "{{$.PrimaryResourceId}}
resource "google_cloudfunctions_function" "{{$.PrimaryResourceId}}" {
name = "{{index $.Vars "neg_name"}}"
description = "My function"
runtime = "nodejs10"
runtime = "nodejs20"

available_memory_mb = 128
source_archive_bucket = google_storage_bucket.bucket.name
Expand Down
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/examples/uptime_check_config_synthetic_monitor.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ resource "google_cloudfunctions2_function" "function" {
location = "us-central1"

build_config {
runtime = "nodejs16"
runtime = "nodejs20"
entry_point = "SyntheticFunction" # Set the entry point
source {
storage_source {
Expand Down
2 changes: 1 addition & 1 deletion ...arty/terraform/services/cloudfunctions/data_source_google_cloudfunctions_function_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ resource "google_storage_bucket_object" "archive" {

resource "google_cloudfunctions_function" "function_http" {
name = "%s-http"
runtime = "nodejs14"
runtime = "nodejs20"
description = "test function"
available_memory_mb = 128
source_archive_bucket = google_storage_bucket.bucket.name
Expand Down
2 changes: 1 addition & 1 deletion mmv1/third_party/terraform/services/cloudfunctions/resource_cloudfunctions_function.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ func ResourceCloudFunctionsFunction() *schema.Resource {
"runtime": {
Type: schema.TypeString,
Required: true,
Description: `The runtime in which the function is going to run. Eg. "nodejs12", "nodejs14", "python37", "go111".`,
Description: `The runtime in which the function is going to run. Eg. "nodejs20", "python37", "go111".`,
},

"service_account_email": {
Expand Down
4 changes: 2 additions & 2 deletions ...ird_party/terraform/services/cloudfunctions/resource_cloudfunctions_function_test.go.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,7 +1355,7 @@ resource "google_storage_bucket_object" "cloud_function_zip_object" {

resource "google_cloudfunctions_function" "function" {
name = "%s"
runtime = "nodejs14"
runtime = "nodejs20"
service_account_email = google_service_account.cloud_function_runner.email
entry_point = "echoSecret"
source_archive_bucket = google_storage_bucket.cloud_functions.id
Expand Down Expand Up @@ -1420,7 +1420,7 @@ resource "google_storage_bucket_object" "cloud_function_zip_object" {

resource "google_cloudfunctions_function" "function" {
name = "%s"
runtime = "nodejs14"
runtime = "nodejs20"
service_account_email = google_service_account.cloud_function_runner.email
entry_point = "echoSecret"
source_archive_bucket = google_storage_bucket.cloud_functions.id
Expand Down
2 changes: 1 addition & 1 deletion ..._party/terraform/website/docs/guides/google-continuous-validation.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ resource "google_cloudfunctions2_function" "my-function" {
location = "us-central1"
description = "a new function"
build_config {
runtime = "nodejs12"
runtime = "nodejs20"
entry_point = "helloHttp"
source {
storage_source {
Expand Down
6 changes: 3 additions & 3 deletions mmv1/third_party/terraform/website/docs/r/cloudfunctions_function.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ resource "google_storage_bucket_object" "archive" {
resource "google_cloudfunctions_function" "function" {
name = "function-test"
description = "My function"
runtime = "nodejs16"
runtime = "nodejs20"

available_memory_mb = 128
source_archive_bucket = google_storage_bucket.bucket.name
Expand Down Expand Up @@ -73,7 +73,7 @@ resource "google_storage_bucket_object" "archive" {
resource "google_cloudfunctions_function" "function" {
name = "function-test"
description = "My function"
runtime = "nodejs16"
runtime = "nodejs20"

available_memory_mb = 128
source_archive_bucket = google_storage_bucket.bucket.name
Expand Down Expand Up @@ -109,7 +109,7 @@ The following arguments are supported:
* `name` - (Required) A user-defined name of the function. Function names must be unique globally.

* `runtime` - (Required) The runtime in which the function is going to run.
Eg. `"nodejs16"`, `"python39"`, `"dotnet3"`, `"go116"`, `"java11"`, `"ruby30"`, `"php74"`, etc. Check the [official doc](https://cloud.google.com/functions/docs/concepts/exec#runtimes) for the up-to-date list.
Eg. `"nodejs20"`, `"python39"`, `"dotnet3"`, `"go116"`, `"java11"`, `"ruby30"`, `"php74"`, etc. Check the [official doc](https://cloud.google.com/functions/docs/concepts/exec#runtimes) for the up-to-date list.

- - -

Expand Down
2 changes: 1 addition & 1 deletion mmv1/third_party/tgc/tests/data/example_google_cloudfunctions_function.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
"location": "us-east1",
"name": "my-cf",
"runtime": "nodejs14",
"runtime": "nodejs20",
"timeout": 60,
"trigger_http": true,
"vpcConnector": "vpc-con-cf",
Expand Down
2 changes: 1 addition & 1 deletion mmv1/third_party/tgc/tests/data/example_google_cloudfunctions_function.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ resource "google_vpc_access_connector" "connector" {
resource "google_cloudfunctions_function" "function" {
name = "my-cf"
description = "My CloudFunction"
runtime = "nodejs14"
runtime = "nodejs20"

available_memory_mb = 128
source_archive_bucket = "validator_bucket_local"
Expand Down
Loading