Fix inconsistent stroke width in 'Outline' view mode #2417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keavon
changed the title
|
!build |
|
|
Thanks. You might want to move on to #2007 next which is similar and should be in the same file. |
Keavon
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2387
This issue occurs in vectors that do not have a stroke node and have a transform scale other than 1. The problem arises because a "stroke" always exists, even if it is not explicitly present in the node graph—it simply defaults to a stroke with a weight of 0. However, in these cases, stroke.transform is not correctly set.
Since the stroke is considered valid regardless, the original check prevented it from falling back to instance.transform() when necessary. To fix this, I added an additional check to ensure that the stroke is only treated as valid if its weight is greater than 0. Otherwise, we should use the fallback instead of relying on the default stroke.transform.