Skip to content

Fix inconsistent stroke width in 'Outline' view mode #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 10, 2025
Merged

Fix inconsistent stroke width in 'Outline' view mode #2417

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b5112e5
fix noise pattern parameter issue
EllenGYY Mar 9, 2025
5c8ffa7
removed the commented out line
EllenGYY Mar 9, 2025
23f50be
Merge branch 'GraphiteEditor:master' into fix-outline-mode-stroke-width
EllenGYY Mar 9, 2025
0764fc3
Fix outline mode stroke width not consistent
EllenGYY Mar 10, 2025
7a78bc6
Merge branch 'GraphiteEditor:master' into fix-outline-mode-stroke-width
EllenGYY Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions node-graph/gcore/src/graphic_element/renderer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,12 +445,9 @@ impl GraphicElementRendered for VectorDataTable {
fn render_svg(&self, render: &mut SvgRender, render_params: &RenderParams) {
for instance in self.instances() {
let multiplied_transform = render.transform * instance.transform();
let set_stroke_transform = instance
.instance
.style
.stroke()
.map(|stroke| stroke.transform)
.filter(|transform| transform.matrix2.determinant() != 0.);
// Only consider strokes with non-zero weight, since default strokes with zero weight would prevent assigning the correct stroke transform
let has_real_stroke = instance.instance.style.stroke().filter(|stroke| stroke.weight() > 0.);
let set_stroke_transform = has_real_stroke.map(|stroke| stroke.transform).filter(|transform| transform.matrix2.determinant() != 0.);
let applied_stroke_transform = set_stroke_transform.unwrap_or(instance.transform());
let element_transform = set_stroke_transform.map(|stroke_transform| multiplied_transform * stroke_transform.inverse());
let element_transform = element_transform.unwrap_or(DAffine2::IDENTITY);
Expand All @@ -468,6 +465,7 @@ impl GraphicElementRendered for VectorDataTable {
attributes.push("transform", matrix);

let defs = &mut attributes.0.svg_defs;

let fill_and_stroke = instance
.instance
.style
Expand Down
Loading