Add Vello support for Outline view mode rendering; add non_scaling to strokes (SVG, not yet Vello) #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…YY/Graphite into outline-add-vello-support
…lenGYY/Graphite into add-non-scaling-stroke-option merge local and remote branch
Merge branch 'add-non-scaling-stroke-option' of https://github.com/EllenGYY/Graphite into outline-add-vello-support
Keavon
force-pushed
the
master
branch
4 times, most recently
from
aa7ff13 to
e11b57a
Compare
Keavon
force-pushed
the
outline-add-vello-support
branch
from
6a92b95 to
9732c02
Compare
Keavon
approved these changes
Apr 6, 2025
Keavon
changed the title
This was referenced Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add outline mode rendering for vello. It respects the opacity but ignore blend mode, which is the same behavior as the cpu rendering.
Closes #2007
Uses
vector-effect="non-scaling-stroke"for outline rendering to ensure the stroke is unaffected by the parent’s transform. The normal rendering behavior remains unchanged.Closes #2435