fext[next]: concat_where fieldview embedded #2127
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
added a commit
that referenced
this pull request
Jul 11, 2025
In previous commits the following pieces where already added: - #1998 - #2065 In this PR, `concat_where` tests are added and transformations are integrated. Currently, the feature is disabled for embedded (#2127) and DaCe (PR will be opened once this is merged). Details: - constant folding for `InfinityLiteral`s is added - various tuning to passes for `index`, `concat_where` builtins and `InfinityLiteral` - cases: field constructors now accept `Domain`s (instead of `dict[Dimension, int]) --------- Co-authored-by: Hannes Vogt <[email protected]> Co-authored-by: Till Ehrengruber <[email protected]> Co-authored-by: Edoardo Paone <[email protected]>
philip-paul-mueller
pushed a commit
to philip-paul-mueller/gt4py
that referenced
this pull request
Jul 15, 2025
In previous commits the following pieces where already added: - GridTools#1998 - GridTools#2065 In this PR, `concat_where` tests are added and transformations are integrated. Currently, the feature is disabled for embedded (GridTools#2127) and DaCe (PR will be opened once this is merged). Details: - constant folding for `InfinityLiteral`s is added - various tuning to passes for `index`, `concat_where` builtins and `InfinityLiteral` - cases: field constructors now accept `Domain`s (instead of `dict[Dimension, int]) --------- Co-authored-by: Hannes Vogt <[email protected]> Co-authored-by: Till Ehrengruber <[email protected]> Co-authored-by: Edoardo Paone <[email protected]>
stubbiali
pushed a commit
to stubbiali/gt4py
that referenced
this pull request
Aug 19, 2025
In previous commits the following pieces where already added: - GridTools#1998 - GridTools#2065 In this PR, `concat_where` tests are added and transformations are integrated. Currently, the feature is disabled for embedded (GridTools#2127) and DaCe (PR will be opened once this is merged). Details: - constant folding for `InfinityLiteral`s is added - various tuning to passes for `index`, `concat_where` builtins and `InfinityLiteral` - cases: field constructors now accept `Domain`s (instead of `dict[Dimension, int]) --------- Co-authored-by: Hannes Vogt <[email protected]> Co-authored-by: Till Ehrengruber <[email protected]> Co-authored-by: Edoardo Paone <[email protected]>
havogt
commented
Nov 27, 2025
| # TODO add test | ||
| return Domain(dims=(self,), ranges=(UnitRange(Infinity.NEGATIVE, value + 1),)) | ||
|
|
||
| def __eq__(self, value: Dimension | core_defs.IntegralScalar) -> bool | Domain: |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| def __eq__(self, value: Dimension | core_defs.IntegralScalar) -> bool | Domain: | |
| def __eq__(self, value: Dimension | core_defs.IntegralScalar | Any) -> bool | Domain: |
havogt
commented
Nov 27, 2025
Comment on lines
+121
to
+122
| return Domain(dims=(self,), ranges=(UnitRange(Infinity.NEGATIVE, value + 1),)) | ||
|
|
havogt
commented
Nov 27, 2025
|
|
||
| def __eq__(self, value: Dimension | core_defs.IntegralScalar) -> bool | Domain: | ||
| if isinstance(value, Dimension): | ||
| return self.value == value.value |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| return self.value == value.value | |
| return self.value == value.value and self.kind == value.kind |
???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1713