convert 101 :no_check Casks to HTTPS URLs
#4968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandwalker
added a commit
that referenced
this pull request
Jun 18, 2014
convert 101 `:no_check` Casks to HTTPS URLs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a bit less tested than those in #4967, because they could not be checked against a Casked SHA-256.
However, the downloads from both the HTTP or HTTPS variants had the same checksum, and obvious errors such as empty responses were removed.
Spot-checking looked good.
So, while there may be a few broken links in here, such links are equally broken in both HTTP and HTTPS, so there should be no loss to the user. Therefore I think it should be OK to merge en masse.
Testing this further would be a use case for
brew cask audit --stage, which is mentioned in passing in #4678.