Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward-compatibility to remove naming limitations on Casks #5365

Merged

Conversation

rolandwalker
Copy link
Contributor

Currently, Casks names are constrained by the need to form
valid Ruby class names. This change enables a new syntax,
in which the first line of a Cask will read like

cask :v1 => 'my-app' do

where :v1 indicates the version of the DSL spec.

The current PR merely converts such lines back to the old form

class MyApp < Cask

so the class name is still used behind the scenes, and the naming
limitation is still in effect in practice.

In upcoming months we will alter Casks/docs to use the new syntax,
and then change the backend code to remove the limitation.

Placing the DSL version in the header line means that #4870 would
not be needed.

@phinze
Copy link
Contributor

phinze commented Jul 16, 2014

Got your ping in IRC - This looks great!

I think in the future we may want to at least have the discussion about the redundancy between file name and the name mentioned in the argument, but for now this is a major step forward.

I am definitely +1 for getting a version into the DSL syntax. Makes future changes more straightforward.

I will try and take a look at the implementation in more detail tonight or tomorrow. But I'm definitely on board with the direction!

This was referenced Jul 18, 2014
@rolandwalker
Copy link
Contributor Author

This is the last item for #4688, so I'd like to merge (as soon as I get the encoding issue correct).

Currently, Casks names are constrained by the need to form
valid Ruby class names.  This change enables a new syntax,
in which the first line of a Cask will read like
```ruby
cask :v1 => 'my-app' do
```
where :v1 refers to the version of the DSL spec.
rolandwalker added a commit that referenced this pull request Jul 28, 2014
forward-compatibility to remove naming limitations on Casks
@rolandwalker rolandwalker merged commit 3d9ea33 into Homebrew:master Jul 28, 2014
@rolandwalker rolandwalker deleted the remove_caskname_limitations branch July 28, 2014 18:18
@rolandwalker rolandwalker mentioned this pull request Sep 11, 2014
9 tasks
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants