datree: build using go version 1.16 #84484
Conversation
- [X] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/HEAD/CONTRIBUTING.md)? - [X] Have you ensured that your commits follow the [commit style guide](https://docs.brew.sh/Formula-Cookbook#commit)? - [X] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change? - [X] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting? - [X] Is your test running fine `brew test <formula>`, where `<formula>` is the name of the formula you're submitting? - [X] Does your build pass `brew audit --strict <formula>` (after doing `brew install --build-from-source <formula>`)? If this is a new formula, does it pass `brew audit --new <formula>`? -----
| end | ||
|
|
||
| depends_on "go" => :build | ||
| depends_on "go@1.16" => :build |
There was a problem hiding this comment.
When installing datree using brew install datree and then running datree version, I encounter this error:
fatal error: unexpected signal during runtime execution
but using [email protected] datree works fine.
I'm still investigating this issue's source (I suspect it is related to a specific x/sys version) but until then I would like to pin the go version so users will be able to use it.
There was a problem hiding this comment.
We also run datree version, among other things in CI after building the formula. Why didn't that error in #84424?
Is there a tracking issue for the problem?
There was a problem hiding this comment.
Hi @carlocab,
At the moment running brew install datree downloads datree succesfully but running datree results in panic. datree is not building well with 1.17 version.
Link to the issue: datreeio/datree#159
This is also similar to #84487
We need to fix this because this is affecting all macos users
There was a problem hiding this comment.
Well, it seems to be all macOS users -1 because I can't reproduce the issue when running the same commands as in the issue.
There was a problem hiding this comment.
You're right. We can't find the exact reason why this is not working for our users. Can we push this fix in the meanwhile until we find a solution for this issue?
There was a problem hiding this comment.
at least for me, brew test datree passes but directly running datree version produces the stacktrace
There was a problem hiding this comment.
to follow up here, we did not catch this error because it does not produce with TERM=dumb, which our test environment sets
|
it should be fixed by updating Close for now. |
closes #159 closes Homebrew/homebrew-core#84484 Signed-off-by: Rui Chen <[email protected]>
* feat: remove commits by travis during builds * fix: bump travis version * build: update x/sys to support go 1.17 (#160) closes #159 closes Homebrew/homebrew-core#84484 Signed-off-by: Rui Chen <[email protected]> * feat: bump version Co-authored-by: rui <[email protected]>
7 participants
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?