Self service: fix timing attack #3012
Open
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compare icinga_host.api_key ("known_string") via hash_equals().
lippserd
approved these changes
Dec 15, 2025
Member
|
@raviks789 Please feel free to merge. |
Al2Klimov
commented
Jan 16, 2026
Member
Author
Al2Klimov
left a comment
Al2Klimov
left a comment
There was a problem hiding this comment.
Still works perfectly:
[root@ak-fedora director]# grep 'Windows NT' /var/log/httpd/access_log |grep 16/Jan/2026
10.27.1.23 - - [16/Jan/2026:16:29:18 +0000] "POST /icingaweb2/director/self-service/powershell-parameters?key=f23ace7f43e6322c1d574cced52d16008f1ea20b HTTP/1.1" 200 478 "-" "Mozilla/5.0 (Windows NT; Windows NT 6.3; en-US) WindowsPowerShell/4.0"
10.27.1.23 - - [16/Jan/2026:16:29:20 +0000] "POST /icingaweb2/director/self-service/register-host?name=akws12f&key=f23ace7f43e6322c1d574cced52d16008f1ea20b HTTP/1.1" 200 43 "-" "Mozilla/5.0 (Windows NT; Windows NT 6.3; en-US) WindowsPowerShell/4.0"
10.27.1.23 - - [16/Jan/2026:16:29:20 +0000] "POST /icingaweb2/director/self-service/powershell-parameters?key=eba5da316dcbff2f974af5d005ffc4aebac08363 HTTP/1.1" 200 779 "-" "Mozilla/5.0 (Windows NT; Windows NT 6.3; en-US) WindowsPowerShell/4.0"
10.27.1.23 - - [16/Jan/2026:16:29:20 +0000] "POST /icingaweb2/director/self-service/ticket?key=eba5da316dcbff2f974af5d005ffc4aebac08363 HTTP/1.1" 200 43 "-" "Mozilla/5.0 (Windows NT; Windows NT 6.3; en-US) WindowsPowerShell/4.0"
[root@ak-fedora director]#
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare icinga_host.api_key ("known_string") via hash_equals().
Explicitly requested by @raviks789 in #2968 (comment).