Skip to content

Self service: fix timing attack #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raviks789 merged 1 commit into from
Jan 19, 2026
+7 −5
Merged

Self service: fix timing attack #3012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions library/Director/Objects/IcingaHost.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,13 +585,15 @@ public static function loadWithApiKey($key, Db $db)
$query = $db->getDbAdapter()
->select()
->from('icinga_host')
->where('api_key = ?', $key);
->where('api_key IS NOT NULL')
->query();

$result = self::loadAll($db, $query);
if (count($result) !== 1) {
throw new NotFoundError('Got invalid API key "%s"', $key);
foreach ($query as $row) {
if (hash_equals($row->api_key, $key)) {
return (new static())->setConnection($db)->setDbProperties($row);
}
}

return current($result);
throw new NotFoundError('Got invalid API key "%s"', $key);
}
}
Loading