Upgrade ledger, consensus, network, plutus for cardano-node 10.6 #954

carbolymer · 2025-09-11T07:01:49Z

Changelog

- description: |
    Upgrade ledger: cardano-protocol-tpraos-1.4.1.0, cardano-ledger-shelley-test-1.7.0.0, cardano-ledger-shelley-1.17.0.0, cardano-ledger-mary-1.9.0.0, cardano-ledger-dijkstra-0.1.0.0, cardano-ledger-core-1.18.0.0, cardano-ledger-conway-1.20.0.0, cardano-ledger-byron-1.2.0.0, cardano-ledger-binary-1.7.0.0, cardano-ledger-babbage-1.12.0.0, cardano-ledger-api-1.12.0.0, cardano-ledger-alonzo-1.14.0.0, cardano-data-1.2.4.1, cardano-crypto-wrapper-1.6.1.0
    Upgrade consensus: ouroboros-consensus-protocol-0.13.0.0, ouroboros-consensus-diffusion-0.24.0.0, ouroboros-consensus-0.28.0.0, ouroboros-consensus-cardano-0.26.0.0
    Upgrade network: ouroboros-network-protocols-0.12.0.0, ouroboros-network-framework-0.14.0.0, ouroboros-network-api-0.11.0.0, ouroboros-network-0.18.0.0
    Upgrade plutus-core-1.53, plutus-ledger-api-1.53
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...
# uncomment at least one main project this PR is associated with
  projects:
   - cardano-api
   - cardano-api-gen
  # - cardano-rpc
  # - cardano-wasm

Context

Dependencies upgrade in preparation for node 10.6 release

Checklist

Commit sequence broadly makes sense and commits have useful messages
New tests are added if needed and existing tests are updated. See Running tests for more details
Self-reviewed the diff

- QueryAccountState returns `ChainAccountState` instead of `AccountState` - Use updated consensus queries `GetStakeDistribution2` and `GetPoolDistr2`

`ConstitutionPurpose`

…s or scripts

…lease

carbolymer

LGTM

Jimbo4350

LGTM, few minor comments

cardano-api/src/Cardano/Api/Consensus/Internal/Mode.hs

Jimbo4350 · 2025-10-22T15:21:36Z

cardano-api/src/Cardano/Api/Genesis/Internal.hs

-      Map.toList $
-        fromJust $
-          extractCostModelParamsLedgerOrder mCostModel
+      -- all geneses should contain only the number of cost model params equal to the initial number


What does this mean?

Jimbo4350 · 2025-10-22T15:31:31Z

cardano-api/src/Cardano/Api/Tx/Internal/Body.hs

+    LedgerProtocolParameters pp <- Ledger.maybeToStrictMaybe mTxProtocolParams
+    -- This logic is copied from ledger, because their code is not reusable
+    -- c.f. https://github.com/IntersectMBO/cardano-ledger/commit/5a975d9af507c9ee835a86d3bb77f3e2670ad228#diff-8236dfec9688f22550b91fc9a87af9915523ab9c5bd817218ecceec8ca7a789bR282
+    let shouldCalculateHash =


Seems like an unnecessary check. What's the benefit of calling guard here vs letting hashScriptIntegrity return SNothing? The guard is guarding the guard.

Because hashScriptIntegrity is changed now and does not return SNothing.

We can use mkScriptIntegrity. Not important for this PR though.

We could, but you'd have to build whole Tx era to use it, which results in a lot of boilerplate. We are using convPParamsToScriptIntegrityHash before we start building a transaction so it'd result in a code duplication. Tbh it would be easier to open a PR to ledger to undo requirement of Tx era.

Jimbo4350 · 2025-10-22T15:33:56Z

cardano-api/test/cardano-api-test/Test/Cardano/Api/CBOR.hs


-prop_text_envelope_roundtrip_tx_CBOR :: Property
-prop_text_envelope_roundtrip_tx_CBOR = H.property $ do
+_prop_text_envelope_roundtrip_tx_CBOR :: Property


Do we still want this disabled?

Jimbo4350 · 2025-10-22T15:35:39Z

cardano-api/test/cardano-api-test/Test/Cardano/Api/Transaction/Autobalance.hs

-  stakeCred <- forAll genStakeCredential
+  -- that's the same stake credential as in UTXO
+  lStakeCred@(L.KeyHashObj kh) <-
+    pure $ mkCredential "keyHash-ebe9de78a37f84cc819c0669791aa0474d4f0a764e54b9f90cfe2137"


Given that (as I understand it) the fee increase is deterministic can we go back to using genStakeCredential?

…lease

carbolymer changed the title ~~Jordan/10.6 node release~~ [DRAFT] Jordan/10.6 node release Sep 11, 2025

carbolymer marked this pull request as ready for review September 11, 2025 07:41

carbolymer requested review from a team, CarlosLopezDeLara, Jimbo4350, dcoutts, disassembler, erikd, kevinhammond, newhoggy and palas as code owners September 11, 2025 07:41

carbolymer force-pushed the jordan/10.6-node-release branch 5 times, most recently from 9796d54 to f83f795 Compare September 11, 2025 14:03

Jimbo4350 force-pushed the jordan/10.6-node-release branch from ffca5b1 to 4741b1d Compare September 11, 2025 21:47

ana-pantilie mentioned this pull request Sep 16, 2025

Node release v10.6.0 IntersectMBO/cardano-node#6233

Open

8 tasks

carbolymer mentioned this pull request Sep 16, 2025

Disable Alonzo Genesis cost models validation, since it is done by ledger now #958

Merged

3 tasks

carbolymer force-pushed the jordan/10.6-node-release branch 2 times, most recently from cf3825b to 833aa4e Compare September 19, 2025 15:58

Jimbo4350 added 9 commits September 22, 2025 14:45

Add DijkstraEra era to CardanoEra era

16bc9cc

Add ShelleyBasedEraDijkstra to ShelleyBasedEra era

001d246

Add Dijkstra era to eons

a28a2b1

Add DijkstraEra to Era era

780947b

COMBINE ME: cabal file updates

87a01f4

Update QueryInShelleyBasedEra era result

47f4e7a

- QueryAccountState returns `ChainAccountState` instead of `AccountState` - Use updated consensus queries `GetStakeDistribution2` and `GetPoolDistr2`

Update makeShelleyTransactionBody with Dijkstra era

176954c

Update ledger types PParamUpdatePurpose, CommitteePurpose and

64ee3aa

`ConstitutionPurpose`

Propagate ChainAccountState

120135d

palas added 2 commits September 23, 2025 21:51

Fix wasm32 build

6a71053

Update cache for wasm32

aa2acde

palas force-pushed the jordan/10.6-node-release branch from 6cfae60 to aa2acde Compare September 24, 2025 16:15

jasagredo and others added 7 commits October 2, 2025 17:03

Bump ouroboros-consensus versions

cee9b20

Add L.Era* constraints to ShelleyBasedEra

02a2274

Add Dijkstra Genesis defaults

bcb16bf

Export AsDijkstraEra

845b761

Fix script hash calculation for transactions without redeemers, datum…

02a27d0

…s or scripts

Add SRP for plutus

ef9796d

Fix wrong CBOR deserialisation in pool distribution query

7b990ba

carbolymer force-pushed the jordan/10.6-node-release branch from 82d12a6 to 7b990ba Compare October 16, 2025 12:05

ana-pantilie and others added 7 commits October 16, 2025 15:11

Update plutus srp

9060669

Fix tests compilation issues

1c46afa

Fix transaction autobalancing tests

6ff6731

Remove Plutus SRP, update CHaP index

79163b1

Update CHaP index

a6be460

Merge remote-tracking branch 'origin/master' into jordan/10.6-node-re…

26ff608

…lease

Formatting

84078d2

carbolymer commented Oct 22, 2025

View reviewed changes

carbolymer changed the title ~~[DRAFT] Jordan/10.6 node release~~ Upgrade ledger, consensus, network, plutus for cardano-node 10.6 Oct 22, 2025

Jimbo4350 approved these changes Oct 22, 2025

View reviewed changes

carbolymer added 2 commits October 22, 2025 19:08

Fix pattern match on consensus era

e28dd6f

Address remarks

a73f17f

carbolymer enabled auto-merge October 22, 2025 17:25

Merge remote-tracking branch 'origin/master' into jordan/10.6-node-re…

ef9d4d5

…lease

carbolymer added this pull request to the merge queue Oct 23, 2025

Merged via the queue into master with commit 73427d0 Oct 23, 2025
26 of 41 checks passed

carbolymer deleted the jordan/10.6-node-release branch October 23, 2025 11:49

carbolymer mentioned this pull request Oct 23, 2025

10.6 Node Release Final Integration #935

Closed

3 tasks

Upgrade ledger, consensus, network, plutus for cardano-node 10.6 #954

Upgrade ledger, consensus, network, plutus for cardano-node 10.6 #954

Uh oh!

Conversation

carbolymer commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Context

Checklist

Uh oh!

carbolymer left a comment

Choose a reason for hiding this comment

Uh oh!

Jimbo4350 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jimbo4350 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

carbolymer Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Jimbo4350 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

carbolymer Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jimbo4350 Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carbolymer Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jimbo4350 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

carbolymer Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Jimbo4350 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

carbolymer commented Sep 11, 2025 •

edited

Loading

carbolymer Oct 22, 2025 •

edited

Loading

Jimbo4350 Oct 22, 2025 •

edited

Loading

carbolymer Oct 23, 2025 •

edited

Loading