Skip to content

PlutusV3: Renamed fromGHC to fromHaskellRatio #5463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bezirg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PlutusV3: Renamed fromGHC to fromHaskellRatio #5463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/cardano-ledger-core/src/Cardano/Ledger/Plutus/TxInfo.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ txOutSourceToText = \case
TxOutFromOutput txIx -> "Output: " <> T.pack (show txIx)

transBoundedRational :: BoundedRational r => r -> PV3.Rational
transBoundedRational = PV3.fromGHC . unboundRational
transBoundedRational = PV3.fromHaskellRatio . unboundRational
Copy link
Collaborator

@lehins lehins Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bezirg, which version of plutus-ledger-api started exporting fromHaskellRatio? We need to add a lower bound in the cabal file on that version in order to make sure cabal doesn't try to build an incompatible version.

Copy link
Collaborator Author

@bezirg bezirg Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be plutus 1.56.0.0 which is not released yet. @Unisay is on it to release it with the way you proposed in ChaP


transDataHash :: DataHash -> PV1.DatumHash
transDataHash safe = PV1.DatumHash (transSafeHash safe)
Expand Down
Loading