[MOB-12231] refactor-classes-to-reduce-circular-dependencies #731

lposen · 2025-10-07T17:48:55Z

🔹 JIRA Ticket(s) if any

MOB-12231

✏️ Description

Please provide a brief description of what this pull request does.

…SDK initialization and logging

…ions and usage examples

qltysh · 2025-10-07T17:50:56Z

4 new issues

Tool	Category	Rule	Count
qlty	Structure	Function with many parameters (count = 4): initialize2WithApiKey	4

_{This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.}

src/core/classes/IterableApi.ts

src/core/classes/IterableAuthManager.ts

src/core/constants/defaults.ts

…lure' into MOB-12231-refactor-classes-to-reduce-circular-dependencies

src/core/classes/IterableApi.ts

…lure' into MOB-12231-refactor-classes-to-reduce-circular-dependencies

src/core/classes/IterableApi.ts

…rectly in relevant classes

github-actions · 2025-10-09T11:47:15Z

Lines	Statements	Branches	Functions
	50.65% (272/537)	20.72% (40/193)	48% (96/200)

qltysh · 2025-10-09T11:47:22Z

Diff Coverage: The code coverage on the diff in this pull request is 83.1%.

Total Coverage: This PR will increase coverage by 4.07%.

File Coverage Changes

Path	File Coverage Δ	Indirect
src/core/classes/Iterable.ts	1.4
src/core/classes/IterableApi.ts	82.7
src/core/classes/IterableAuthManager.ts	66.7
src/inApp/classes/IterableInAppManager.ts	10.4
src/inbox/classes/IterableInboxDataModel.ts	0.2

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

_{This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.}

src/core/classes/IterableApi.ts

…rectly in the Iterable class

src/core/classes/IterableApi.ts

qltysh · 2025-10-09T11:59:01Z

src/core/classes/IterableApi.ts

+  static initialize2WithApiKey(
+    apiKey: string,
+    config: IterableConfig = new IterableConfig(),
+    version: string,
+    apiEndPoint: string


Function with many parameters (count = 4): initialize2WithApiKey [qlty:function-parameters]

qltysh · 2025-10-09T11:59:01Z

src/core/classes/IterableApi.ts

+  static trackPushOpenWithCampaignId(
+    campaignId: number,
+    templateId: number,
+    messageId: string | null | undefined,
+    appAlreadyRunning: boolean,
+    dataFields?: unknown


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qltysh · 2025-10-09T11:59:01Z

src/core/classes/IterableApi.ts

+  static trackInAppClose(
+    message: IterableInAppMessage,
+    location: IterableInAppLocation,
+    source: IterableInAppCloseSource,
+    clickedUrl?: string


Function with many parameters (count = 4): trackInAppClose [qlty:function-parameters]

qltysh · 2025-10-09T11:59:02Z

src/core/classes/IterableApi.ts

+  static updateSubscriptions(
+    emailListIds: number[] | null,
+    unsubscribedChannelIds: number[] | null,
+    unsubscribedMessageTypeIds: number[] | null,
+    subscribedMessageTypeIds: number[] | null,
+    campaignId: number,
+    templateId: number


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

Ayyanchira

Partially reviewed

Ayyanchira · 2025-10-09T22:27:11Z

package.json

    "prepare": "yarn build",
-    "release": "release-it"
+    "release": "release-it",
+    "circ": "npx madge --circular --extensions ts ./"


Is it a dedicated package to results circular dependency?

Ayyanchira · 2025-10-09T22:28:09Z

src/core/classes/Iterable.ts

 import type { IterableCommerceItem } from './IterableCommerceItem';
 import { IterableConfig } from './IterableConfig';
 import { IterableLogger } from './IterableLogger';
 import type { IterableAuthFailure } from '../types/IterableAuthFailure';


Import 'type' is removed above. Is this one ok?

Ayyanchira · 2025-10-09T22:29:02Z

src/core/classes/Iterable.ts


 const RNEventEmitter = new NativeEventEmitter(RNIterableAPI);

+const defaultConfig = new IterableConfig();


Not sure how default implementation comes into play. Any possibility of regression?

lposen added 6 commits October 7, 2025 09:17

feat: refactor Iterable class and introduce IterableApi for improved …

e78a6ea

…SDK initialization and logging

feat: add authManager to Iterable class

1ff7740

refactor: replace RNIterableAPI calls with IterableApi methods

1a8fa41

docs: replace RNIterableAPI with IterableApi in IterableInAppManager

72d066a

refactor: integrate IterableApi methods in IterableInboxDataModel

510c581

docs: enhance IterableApi documentation with detailed method descript…

564bcbd

…ions and usage examples

qltysh bot reviewed Oct 7, 2025

View reviewed changes

Merge branch 'jwt/MOB-11032-task-4-ios-bridge-retrypolicy-and-authfai…

8aa92c1

…lure' into MOB-12231-refactor-classes-to-reduce-circular-dependencies

qltysh bot reviewed Oct 9, 2025

View reviewed changes

src/core/classes/IterableApi.ts Show resolved Hide resolved

src/core/classes/IterableApi.ts Show resolved Hide resolved

src/core/classes/IterableApi.ts Show resolved Hide resolved

src/core/classes/IterableApi.ts Show resolved Hide resolved

Merge branch 'jwt/MOB-11032-task-4-ios-bridge-retrypolicy-and-authfai…

2e9d116

…lure' into MOB-12231-refactor-classes-to-reduce-circular-dependencies

qltysh bot reviewed Oct 9, 2025

View reviewed changes

src/core/classes/IterableApi.ts Show resolved Hide resolved

src/core/classes/IterableApi.ts Show resolved Hide resolved

src/core/classes/IterableApi.ts Show resolved Hide resolved

src/core/classes/IterableApi.ts Show resolved Hide resolved

refactor: remove default constants module and instantiate defaults di…

a9f46c1

…rectly in relevant classes

qltysh bot reviewed Oct 9, 2025

View reviewed changes

src/core/classes/IterableApi.ts Show resolved Hide resolved

src/core/classes/IterableApi.ts Show resolved Hide resolved

src/core/classes/IterableApi.ts Show resolved Hide resolved

src/core/classes/IterableApi.ts Show resolved Hide resolved

lposen added 2 commits October 9, 2025 04:54

refactor: instantiate IterableInAppManager and IterableAuthManager di…

01c7919

…rectly in the Iterable class

refactor: remove circular dependency comments in Iterable class

382164d

qltysh bot reviewed Oct 9, 2025

View reviewed changes

src/core/classes/IterableApi.ts Show resolved Hide resolved

src/core/classes/IterableApi.ts Show resolved Hide resolved

src/core/classes/IterableApi.ts Show resolved Hide resolved

src/core/classes/IterableApi.ts Show resolved Hide resolved

chore: add circular dependency check script to package.json

a7ff561

qltysh bot reviewed Oct 9, 2025

View reviewed changes

lposen marked this pull request as ready for review October 9, 2025 19:23

Ayyanchira self-requested a review October 9, 2025 22:31

Ayyanchira reviewed Oct 9, 2025

View reviewed changes


		const RNEventEmitter = new NativeEventEmitter(RNIterableAPI);

		const defaultConfig = new IterableConfig();

[MOB-12231] refactor-classes-to-reduce-circular-dependencies #731

Are you sure you want to change the base?

[MOB-12231] refactor-classes-to-reduce-circular-dependencies #731

Conversation

lposen commented Oct 7, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔹 JIRA Ticket(s) if any

✏️ Description

Uh oh!

qltysh bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

4 new issues

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qltysh bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qltysh bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

qltysh bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

qltysh bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

qltysh bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Ayyanchira left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ayyanchira Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Ayyanchira Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Ayyanchira Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lposen commented Oct 7, 2025 •

edited by atlassian bot

Loading

qltysh bot commented Oct 7, 2025 •

edited

Loading

github-actions bot commented Oct 9, 2025 •

edited

Loading

qltysh bot commented Oct 9, 2025 •

edited

Loading

Ayyanchira left a comment •

edited

Loading