-
Notifications
You must be signed in to change notification settings - Fork 40
[MOB-12231] refactor-classes-to-reduce-circular-dependencies #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
lposen
wants to merge
23
commits into
jwt/MOB-11032-task-4-ios-bridge-retrypolicy-and-authfailure
from
MOB-12231-refactor-classes-to-reduce-circular-dependencies
Closed
Changes from 6 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
e78a6ea
feat: refactor Iterable class and introduce IterableApi for improved …
lposen 1ff7740
feat: add authManager to Iterable class
lposen 1a8fa41
refactor: replace RNIterableAPI calls with IterableApi methods
lposen 72d066a
docs: replace RNIterableAPI with IterableApi in IterableInAppManager
lposen 510c581
refactor: integrate IterableApi methods in IterableInboxDataModel
lposen 564bcbd
docs: enhance IterableApi documentation with detailed method descript…
lposen 8aa92c1
Merge branch 'jwt/MOB-11032-task-4-ios-bridge-retrypolicy-and-authfai…
lposen 2e9d116
Merge branch 'jwt/MOB-11032-task-4-ios-bridge-retrypolicy-and-authfai…
lposen a9f46c1
refactor: remove default constants module and instantiate defaults di…
lposen 01c7919
refactor: instantiate IterableInAppManager and IterableAuthManager di…
lposen 382164d
refactor: remove circular dependency comments in Iterable class
lposen a7ff561
chore: add circular dependency check script to package.json
lposen eb2c376
refactor: remove unnecessary type-only import to simplify Iterable class
lposen b10097a
refactor: streamline logging by removing logger instances and using s…
lposen b776414
test: add comprehensive tests for IterableLogger class, addressing lo…
lposen 65cb551
feat: add authentication manager to Iterable class
lposen 5bbb5fc
refactor: remove pauseAuthRetries method from Iterable class
lposen 92fbff1
chore: disable TSDoc syntax rule for IterableRetryBackoff enum
lposen e94100f
feat: add pauseAuthRetries method to authentication manager and enhan…
lposen 5e4e579
Merge branch 'jwt/MOB-10946-task-2-authfailure-and-retrypolicy-ts-cla…
lposen 3737d57
fix: improve null safety in IterableInAppMessage.fromViewToken method
lposen 2d6c381
Merge branch 'jwt/MOB-10947-task-3-android-retrypolicy-config-at-andr…
lposen c6b62d0
refactor: remove instantiation of IterableInAppManager and IterableAu…
lposen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import { defaultLogger } from '../constants/defaults'; | ||
| import { IterableLogger } from './IterableLogger'; | ||
| import { IterableApi } from './IterableApi'; | ||
|
|
||
| /** | ||
| * Manages the authentication for the Iterable SDK. | ||
| * | ||
| * @example | ||
| * ```typescript | ||
| * const config = new IterableConfig(); | ||
| * const logger = new IterableLogger(config); | ||
| * const authManager = new IterableAuthManager(logger); | ||
| * ``` | ||
| */ | ||
| export class IterableAuthManager { | ||
| /** | ||
| * The logger for the Iterable SDK. | ||
| */ | ||
| static logger: IterableLogger = defaultLogger; | ||
|
|
||
| constructor(logger: IterableLogger) { | ||
| IterableAuthManager.logger = logger; | ||
| } | ||
|
|
||
| /** | ||
| * Pause the authentication retry mechanism. | ||
| * | ||
| * @param pauseRetry - Whether to pause the authentication retry mechanism | ||
| * | ||
| * @example | ||
| * ```typescript | ||
| * const authManager = new IterableAuthManager(); | ||
| * authManager.pauseAuthRetries(true); | ||
| * ``` | ||
| */ | ||
| pauseAuthRetries(pauseRetry: boolean) { | ||
| return IterableApi.pauseAuthRetries(pauseRetry); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { IterableInAppManager } from '../../inApp/classes/IterableInAppManager'; | ||
qltysh[bot] marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| import { IterableAuthManager } from '../classes/IterableAuthManager'; | ||
| import { IterableConfig } from '../classes/IterableConfig'; | ||
| import { IterableLogger } from '../classes/IterableLogger'; | ||
|
|
||
| export const defaultConfig = new IterableConfig(); | ||
| export const defaultLogger = new IterableLogger(defaultConfig); | ||
| export const defaultInAppManager = new IterableInAppManager(defaultLogger); | ||
| export const defaultAuthManager = new IterableAuthManager(defaultLogger); | ||
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.