Skip to content

Cleanup and generalize functions of Hermitian matrices #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

araujoms
Copy link
Collaborator

@araujoms araujoms commented May 7, 2025

This mostly removes duplicated code. The only intentional change is to allow matrix functions to apply to any Hermitian matrix, as opposed to only Hermitian{<:Complex}. This allows them to work for matrices of quaternions, for example.

@araujoms araujoms changed the title Cleanup and generalize functions of Hermitian matrix Cleanup and generalize functions of Hermitian matrices May 7, 2025
Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.76%. Comparing base (7f354f4) to head (098966a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/symmetric.jl 95.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
+ Coverage   93.75%   93.76%   +0.01%     
==========================================
  Files          34       34              
  Lines       15778    15743      -35     
==========================================
- Hits        14792    14762      -30     
+ Misses        986      981       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah
Copy link
Member

@araujoms Can I invite you to have commit access to the repo (if you don't already have it)?

@araujoms
Copy link
Collaborator Author

araujoms commented May 7, 2025

Sure, that would be nice, thanks! (no, I don't have it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants