-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VersionInfo: Mimic github's hash styling #7694
base: master
Are you sure you want to change the base?
Conversation
Hmm... Something about Edit: Yeah, it's because PRs use merge-commits. I'm not sure this can be easily avoided. |
So this does as described, but the merge commit ends up in the file (whereas the PR commit ends up on the download button). It would be really nice to have these match so that we're not trying to cross reference merge-commits to their respective branch commits. |
I believe I found a way to get them to match. 🤞 |
Nope 😆 |
Got it! Next I'll test the behavior with a force-commit by squashing everything down. Edit: Works. |
The problem:
g
.For example, this is what our software may be versioned:
gb353cf1e7
(taken fromlmms-1.3.0-alpha.1.760+pr7693.gb353cf1e7-linux-aarch64.AppImage
)This is the commit hash that it references:
Or put simpler:
This makes it visually more difficult to correlate a build to a commit hash.
This PR simply shortens the hash to match github and snags the commit hash from the merge commit description.
Adjacent tasks: