[ARRISAPOL-3803] Notify buffering state also in pipeline state transition #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradeep-raveendranpillai-infosys
previously approved these changes
Oct 3, 2025
https://bugs.webkit.org/show_bug.cgi?id=300041 Reviewed by Philippe Normand. Sometimes, in a downstream multimedia player, regular video playback remains paused after seek instead of resuming automatically. It will play normally when play() or another seek operation are manually triggered. Log analys shows that in the failing case the browser missed the state transition to 'HaveCurrentData', and application can't resume playback after seek. It was missed because it happened the gstreamer pipeline remains in state transition for too long and can't process buffering events. Normally it goes: seek -> Paused pipeline -> buffering (HaveCurrentData) -> finish_buffering(HaveEnoughData) -> start_playback. However, in the failing case, seek takes too long (~2sec) to set the PAUSED state on the pipeline and we are missing the buffering(HaveCurrentData) stage. See: WebPlatformForEmbedded#1561 This patch returns the player readyState to HaveCurrentData and the networkState to Loading when a seek is being processed. The states will reach their final values as soon as the async state transition caused by the seek finishes. Original author: Volodymyr Ogorodnik (https://github.com/volodymyr-ogorodnik-red) * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::updateStates): Reset readyState and networkState to HaveCurrentData and Loading while the player is in an async state transition (in a seek) and buffering. Canonical link: https://commits.webkit.org/300933@main
volodymyr-ogorodnik-red
force-pushed
the
vogorodnik/ARRISAPOL-3803_euronews_fix
branch
from
38147cd to
00248c7
Compare
marcin-mielczarczyk-red
approved these changes
Oct 6, 2025
marcin-mielczarczyk-red
requested a review
from pradeep-raveendranpillai-infosys
amol-virnodkar-infosys
approved these changes
Oct 6, 2025
pradeep-raveendranpillai-infosys
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream fix is discussed in WebPlatformForEmbedded#1561
and WebPlatformForEmbedded#1556
But no working solution so far.
This change at least helps on resume from paused state while 1-2s freezes are still visible.