Skip to content

[ARRISAPOL-3803] Notify buffering state also in pipeline state transition #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

[ARRISAPOL-3803] Notify buffering state also in pipeline state transition #516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2743,6 +2743,13 @@ void MediaPlayerPrivateGStreamer::updateStates()
GST_DEBUG_OBJECT(pipeline(), "Async: State: %s, pending: %s", gst_element_state_get_name(m_currentState), gst_element_state_get_name(pending));
// Change in progress.

if (m_currentState == GST_STATE_PAUSED && m_isBuffering) {
// If we are buffering, we could miss HaveCurrentData state if buffering finished before the transition completes.
GST_DEBUG_OBJECT(pipeline(), "Async: [Buffering] still buffering, so force HaveCurrentData.");
m_readyState = MediaPlayer::ReadyState::HaveCurrentData;
m_networkState = MediaPlayer::NetworkState::Loading;
}

// Delay the m_isBuffering change by returning it to its previous value. Without this, the false --> true change
// would go unnoticed by the code that should trigger a pause.
if (m_wasBuffering != m_isBuffering && !m_isPaused && m_playbackRate) {
Expand Down