Correct and complete german translation and extend E-Mail-Templates#1177
Open
QuasiMoko wants to merge 1 commit intoLibreBooking:developfrom
Open
Correct and complete german translation and extend E-Mail-Templates#1177QuasiMoko wants to merge 1 commit intoLibreBooking:developfrom
QuasiMoko wants to merge 1 commit intoLibreBooking:developfrom
Conversation
Collaborator
|
Thanks @QuasiMoko I'll try to find some time to help get this merged in. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the German (de_de) locale by improving/expanding email templates and fixing a few localization details (notably date formats and a string typo) to make German notifications more complete and consistent with other locales.
Changes:
- Expanded/added multiple
lang/de_de/*.tplemail templates (greetings, details blocks, links, and several templates that were previously missing). - Standardized many templates to use
{$AppTitle}-Logininstead of hardcoded product names. - Added a de_de-specific
_LoadDates()override and fixed a typo inEmailDisabledinlang/de_de.php.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 21 comments.
Show a summary per file
| File | Description |
|---|---|
| lang/de_de/StartReminderEmail.tpl | Reformats start reminder email into structured HTML with links |
| lang/de_de/ResourceStatusChanged.tpl | Adds missing German template for resource status change emails |
| lang/de_de/ResetPassword.tpl | Expands reset password email to include more context + login link |
| lang/de_de/ReservationSeriesEnding.tpl | Adds missing German template for “series ending” emails |
| lang/de_de/ReservationParticipationActivity.tpl | Adds missing German template for participation activity emails |
| lang/de_de/ReservationInvitation.tpl | Expands invitation email with greeting and clearer structure |
| lang/de_de/ReservationDeleted.tpl | Adds greeting + standardizes login link text |
| lang/de_de/ReservationCreatedAdmin.tpl | Adds greeting + restructures admin reservation created email |
| lang/de_de/ReservationCreated.tpl | Adds greeting + restructures reservation created email |
| lang/de_de/ReservationAvailable.tpl | Adds missing German template for waitlist availability emails |
| lang/de_de/ReportEmail.tpl | Adds greeting + clarifies report origin + standardizes login link |
| lang/de_de/MissedCheckinEmail.tpl | Adds missing German template for missed check-in emails |
| lang/de_de/InviteUser.tpl | Adds missing German template for inviting a user to register |
| lang/de_de/GuestAccountCreation.tpl | Adds missing German template for guest account creation |
| lang/de_de/EndReminderEmail.tpl | Minor formatting/link updates + standardizes login link |
| lang/de_de/AnnouncementEmail.tpl | Adds missing German template for announcement emails |
| lang/de_de/AccountDeleted.tpl | Adds missing German template for account deletion emails |
| lang/de_de/AccountCreationForUser.tpl | Adds missing German template for admin-created accounts |
| lang/de_de/AccountCreation.tpl | Tweaks wording and adds standardized login link |
| lang/de_de/AccountActivation.tpl | Adds line break + standardized login link |
| lang/de_de.php | Adds de_de date formats + fixes “E-Mail” typo in EmailDisabled |
You can also share your feedback on Copilot code review. Take the survey.
| @@ -0,0 +1,18 @@ | |||
| Hallo {$FirstName},<br/> | |||
| @@ -0,0 +1,6 @@ | |||
| Hallo {$FirstName},<br/> | |||
| Reservierungsdetails: | ||
| <br/> | ||
| <br/> | ||
| Hallo {$FirstName},<br/> |
Comment on lines
+5
to
+7
| hat Ihre Einladung abgelehnt. | ||
| {elseif ($InvitationAction == InvitationAction::Join || $InvitationAction == InvitationAction::JoinAll)} | ||
| ist Ihrere Reservierung beigetreten. |
| Hier ist Ihr vorläufiges Passwort: {$TemporaryPassword}<br/> | ||
| Ihr altes Passwort wurde zurückgesetzt und wird nicht mehr funktionieren.<br/> | ||
| <br/> | ||
| Bitte<a href="{$ScriptUrl}"> anmelden </a> und das Passwort ändern. |
| Passwort: {$Password}<br/> | ||
| </br> | ||
| Bitte loggen Sie sich ein, um Ihr Benutzerkonto und Ihre Reservierungen anzupassen.</br> | ||
|
|
| @@ -0,0 +1,17 @@ | |||
| <p> | |||
| Hallo {$FirstName},<br/> | |||
| @@ -1,3 +1,6 @@ | |||
| Hallo {$FirstName},<br/> | |||
| Ihre Reservierung beginnt bald.<br/> | ||
| Reservierungsdetails: | ||
| <p> | ||
| Hallo {$FirstName},<br/> |
| @@ -1,9 +1,13 @@ | |||
| Hier ist Ihr vorläufiges Passwort: {$TemporaryPassword} | |||
| <p> | |||
| Hallo {$FirstName},<br/> | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not familiar with git, so pls sry for any circumustances. THX