Skip to content

feat(snaps): Add AssetSelector #61319

feat(snaps): Add AssetSelector

feat(snaps): Add AssetSelector #61319

Triggered via pull request March 7, 2025 14:21
Status Failure
Total duration 37m 14s
Artifacts 11

main.yml

on: pull_request
Wait for CircleCI workflow status  /  Wait for CircleCI workflow status
33m 39s
Wait for CircleCI workflow status / Wait for CircleCI workflow status
Build storybook  /  Build storybook
3m 35s
Build storybook / Build storybook
Build beta  /  Build beta
8s
Build beta / Build beta
Lint workflows  /  Lint workflows
16s
Lint workflows / Lint workflows
Matrix: Run tests / Unit tests
Matrix: validate-lavamoat-policy-webapp / Validate lavamoat policy webapp
test-lint  /  Test lint
5m 52s
test-lint / Test lint
repository-health-checks  /  Repository health checks
2m 36s
repository-health-checks / Repository health checks
Test storybook  /  Test storybook
7m 2s
Test storybook / Test storybook
validate-lavamoat-policy-build  /  Validate lavamoat policy build
1m 35s
validate-lavamoat-policy-build / Validate lavamoat policy build
prep-build-test-browserify
7m 11s
prep-build-test-browserify
prep-build-test-webpack
1m 21s
prep-build-test-webpack
Run tests  /  Webpack tests
49s
Run tests / Webpack tests
Run tests  /  Integration tests
2m 44s
Run tests / Integration tests
Test circular deps
51s
Test circular deps
Runway  /  Runway
Runway / Runway
Publish prerelease  /  Publish prerelease
3m 5s
Publish prerelease / Publish prerelease
Matrix: run-benchmarks / benchmarks
Run tests  /  Report coverage
0s
Run tests / Report coverage
All jobs completed
0s
All jobs completed
All jobs pass
0s
All jobs pass
Log merge group failure  /  Log merge group failure
Log merge group failure / Log merge group failure
Fit to window
Zoom out
Zoom in

Annotations

15 errors and 10 warnings
test-lint / Test lint: ui/components/app/snaps/snap-ui-asset-selector/snap-ui-asset-selector.tsx#L26
`../../../../hooks/useI18nContext` import should occur before import of `./useSnapAssetDisplay`
test-lint / Test lint: ui/components/app/snaps/snap-ui-asset-selector/useSnapAssetDisplay.tsx#L14
'getInternalAccountByAddress' is defined but never used
test-lint / Test lint: ui/components/app/snaps/snap-ui-asset-selector/useSnapAssetDisplay.tsx#L23
'getCurrentCurrency' is defined but never used
test-lint / Test lint: ui/components/app/snaps/snap-ui-asset-selector/useSnapAssetDisplay.tsx#L29
'getMultichainNetworkConfigurationsByChainId' is defined but never used
test-lint / Test lint
Process completed with exit code 1.
Run tests / Unit tests (4)
Process completed with exit code 1.
Run tests / Unit tests (5)
The job was canceled because "_4" failed.
Run tests / Unit tests (5)
The operation was canceled.
Run tests / Unit tests (3)
The job was canceled because "_4" failed.
Run tests / Unit tests (3)
The operation was canceled.
All jobs pass
Process completed with exit code 1.
test-lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1265
Some tests seem to be commented
test-lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1286
Some tests seem to be commented
test-lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1306
Some tests seem to be commented
test-lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1390
Some tests seem to be commented
test-lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1406
Some tests seem to be commented
test-lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1429
Some tests seem to be commented
test-lint / Test lint: test/e2e/flask/solana/common-solana.ts#L491
'#fb9f18' Hex color values are not allowed. Consider using design tokens instead. For support reach out to the design system team #metamask-design-system on Slack
test-lint / Test lint: ui/components/app/alert-system/alert-modal/alert-modal.tsx#L209
React Hook "useI18nContext" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?
test-lint / Test lint: ui/components/app/assets/asset-list/asset-list-control-bar/asset-list-control-bar.tsx#L83
React Hook useMemo has an unnecessary dependency: 'TEST_CHAINS'. Either exclude it or remove the dependency array. Outer scope values like 'TEST_CHAINS' aren't valid dependencies because mutating them doesn't re-render the component
test-lint / Test lint: ui/components/app/assets/asset-list/asset-list-control-bar/asset-list-control-bar.tsx#L109
React Hook useEffect has missing dependencies: 'allOpts', 'currentNetwork.chainId', 'dispatch', and 'tokenNetworkFilter'. Either include them or remove the dependency array

Artifacts

Produced during runtime
Name Size
benchmark-browserify-pageload
829 Bytes
benchmark-browserify-userActions
196 Bytes
benchmark-webpack-pageload
803 Bytes
benchmark-webpack-userActions
196 Bytes
coverage-integration
827 KB
coverage-unit-1
1.1 MB
coverage-unit-2
1.1 MB
coverage-unit-6
1.1 MB
coverage-webpack
14.6 KB
prep-build-test-browserify
53.9 MB
prep-build-test-webpack
25 MB