Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mms-2045 paste non 0x address #30712

Merged
merged 13 commits into from
Mar 6, 2025
Merged

Conversation

GustavoRSSilva
Copy link
Contributor

@GustavoRSSilva GustavoRSSilva commented Mar 4, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to the send page
  2. enter an 0x addres (ex: eD502cF03Ee709e9858922C565db6B7f264a056f)
  3. Sometime the address is validated, other time just adds the 0x

Screenshots/Recordings

Before

Screenshot 2025-03-04 at 10 14 14

After

Screenshot 2025-03-04 at 10 15 31

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GustavoRSSilva GustavoRSSilva requested a review from a team as a code owner March 4, 2025 10:18
Copy link
Contributor

github-actions bot commented Mar 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Team swaps and bridge label Mar 4, 2025
@GustavoRSSilva GustavoRSSilva requested review from mirceanis and danjm and removed request for mirceanis March 4, 2025 10:30
ghgoodreau
ghgoodreau previously approved these changes Mar 4, 2025
micaelae
micaelae previously approved these changes Mar 4, 2025
@@ -92,9 +92,12 @@ export default class DomainInput extends Component {
!isBurnAddress(input) &&
isValidHexAddress(input, { mixedCaseUseChecksum: true })
) {
onValidAddressTyped(addHexPrefix(input));
const hexInput = addHexPrefix(input);
onChange(hexInput);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This normally warrants a unit test but apparently we have no unit test added for this component.

Also this component used in the send flow which is owned by wallet-ux (regarding codeowners file) team but somehow end-up on confirmations folder. I will do the adjustments after you merge your PR to not get conflicts.

OGPoyraz
OGPoyraz previously approved these changes Mar 5, 2025
@GustavoRSSilva GustavoRSSilva enabled auto-merge March 5, 2025 14:16
micaelae
micaelae previously approved these changes Mar 5, 2025
…tamask-extension into mms-2045-paste-flaky-address
@metamaskbot
Copy link
Collaborator

Builds ready [23a0e0e]
Page Load Metrics (1959 ± 102 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22024951653680327
domContentLoaded155024211922211101
load156224901959212102
domInteractive28108482311
backgroundConnect13108422914
firstReactRender167228188
getState76424199
initialActions01000
loadScripts11301827143617082
setupStore85718157
uiStartup180028062206233112
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 51 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@GustavoRSSilva GustavoRSSilva added this pull request to the merge queue Mar 6, 2025
Merged via the queue into main with commit a24e5dc Mar 6, 2025
74 checks passed
@GustavoRSSilva GustavoRSSilva deleted the mms-2045-paste-flaky-address branch March 6, 2025 12:14
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-swaps-and-bridge Team swaps and bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants