-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mms-2045 paste non 0x address #30712
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ui/pages/confirmations/send/send-content/add-recipient/domain-input.component.js
Outdated
Show resolved
Hide resolved
…tamask-extension into mms-2045-paste-flaky-address
@@ -92,9 +92,12 @@ export default class DomainInput extends Component { | |||
!isBurnAddress(input) && | |||
isValidHexAddress(input, { mixedCaseUseChecksum: true }) | |||
) { | |||
onValidAddressTyped(addHexPrefix(input)); | |||
const hexInput = addHexPrefix(input); | |||
onChange(hexInput); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This normally warrants a unit test but apparently we have no unit test added for this component.
Also this component used in the send flow which is owned by wallet-ux (regarding codeowners file) team but somehow end-up on confirmations folder. I will do the adjustments after you merge your PR to not get conflicts.
…tamask-extension into mms-2045-paste-flaky-address
0257f2a
Builds ready [23a0e0e]
Page Load Metrics (1959 ± 102 ms)
Bundle size diffs
|
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist