Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mms-2045 paste non 0x address #30712

Merged
merged 13 commits into from
Mar 6, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ export default class DomainInput extends Component {
} = this.props;
const input = value.trim();

onChange(input);
if (internalSearch) {
onChange(input);
return null;
}

Expand All @@ -92,9 +92,14 @@ export default class DomainInput extends Component {
!isBurnAddress(input) &&
isValidHexAddress(input, { mixedCaseUseChecksum: true })
) {
onValidAddressTyped(addHexPrefix(input));
const hexInput = addHexPrefix(input);
onChange(hexInput);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This normally warrants a unit test but apparently we have no unit test added for this component.

Also this component used in the send flow which is owned by wallet-ux (regarding codeowners file) team but somehow end-up on confirmations folder. I will do the adjustments after you merge your PR to not get conflicts.

onValidAddressTyped(hexInput);
} else {
onChange(input);
}
} else {
onChange(input);
lookupDomainName(input);
}

Expand Down
Loading