Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump ethereumjs #30716

Merged
merged 39 commits into from
Mar 7, 2025
Merged

chore: bump ethereumjs #30716

merged 39 commits into from
Mar 7, 2025

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Mar 4, 2025

Description

Upgrade all @ethereumjs/* packages including the keyrings and KeyringController since they depend on ethereumjs packages internally.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Mar 4, 2025
@matthewwalsh0 matthewwalsh0 changed the base branch from main to mikesposito/bump-keyring-controller March 4, 2025 11:08
Copy link

socket-security bot commented Mar 4, 2025

@matthewwalsh0
Copy link
Member Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@matthewwalsh0
Copy link
Member Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

No policy changes

Copy link
Contributor

github-actions bot commented Mar 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [81b787b]
Page Load Metrics (2007 ± 77 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17502380200316077
domContentLoaded17312291196114972
load17512390200716077
domInteractive26115472713
backgroundConnect14102463014
firstReactRender157631199
getState66520157
initialActions01000
loadScripts12761803148412761
setupStore96023189
uiStartup192527642285211101

Base automatically changed from mikesposito/bump-keyring-controller to main March 7, 2025 11:15
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review March 7, 2025 11:20
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners March 7, 2025 11:20
@matthewwalsh0 matthewwalsh0 enabled auto-merge March 7, 2025 11:49
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Mar 7, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [880f92b]
Page Load Metrics (2055 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17602328205818790
domContentLoaded16602299200119393
load17482331205518488
domInteractive27118482814
backgroundConnect16149593517
firstReactRender1681312010
getState899272512
initialActions00000
loadScripts12231740152116780
setupStore96120168
uiStartup196828072359219105
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 401.83 KiB (7.01%)
  • ui: 0 Bytes (0.00%)
  • common: 483.74 KiB (4.93%)

Merged via the queue into main with commit 32c9974 Mar 7, 2025
77 checks passed
@matthewwalsh0 matthewwalsh0 deleted the chore/bump-ethereumjs branch March 7, 2025 12:26
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants